Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java

Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + CR comments + added background color to new NTP Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java
deleted file mode 100644
index d032d52caff3d322c48fce7c0c0f9c20fa903159..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetCardItemViewHolder.java
+++ /dev/null
@@ -1,111 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
dgn 2016/03/24 13:56:25 Does not build on GN. Needs to be removed from chr
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.ntp.snippets;
-
-import android.view.LayoutInflater;
-import android.view.View;
-import android.view.View.OnClickListener;
-import android.view.ViewGroup;
-import android.widget.ImageView;
-import android.widget.TextView;
-
-import org.chromium.base.metrics.RecordHistogram;
-import org.chromium.base.metrics.RecordUserAction;
-import org.chromium.chrome.R;
-import org.chromium.chrome.browser.ntp.NewTabPageUma;
-import org.chromium.chrome.browser.ntp.snippets.SnippetsManager.SnippetArticle;
-import org.chromium.chrome.browser.ntp.snippets.SnippetsManager.SnippetListItem;
-
-/**
- * A class that represents the view for a single card snippet.
- */
-class SnippetCardItemViewHolder extends SnippetListItemViewHolder implements View.OnClickListener {
- public TextView mHeadlineTextView;
- public TextView mPublisherTextView;
- public TextView mArticleSnippetTextView;
- public TextView mReadMoreLinkTextView;
- public ImageView mThumbnailView;
- public String mUrl;
- public int mPosition;
-
- /**
- * Creates the CardView object to display snippets information
- *
- * @param parent The parent view for the card
- * @return a CardView object for displaying snippets
- */
- public static View createView(ViewGroup parent) {
- return LayoutInflater.from(parent.getContext())
- .inflate(R.layout.new_tab_page_snippets_card, parent, false);
- }
-
- /**
- * Constructs a SnippetCardItemView item used to display snippets
- *
- * @param cardView The View for the snippet card
- * @param manager The SnippetsManager object used to open an article
- */
- public SnippetCardItemViewHolder(View cardView, SnippetsManager manager) {
- super(cardView, manager);
-
- cardView.setOnClickListener(this);
- mThumbnailView = (ImageView) cardView.findViewById(R.id.article_thumbnail);
- mHeadlineTextView = (TextView) cardView.findViewById(R.id.article_headline);
- mPublisherTextView = (TextView) cardView.findViewById(R.id.article_publisher);
- mArticleSnippetTextView = (TextView) cardView.findViewById(R.id.article_snippet);
- mReadMoreLinkTextView = (TextView) cardView.findViewById(R.id.read_more_link);
- mReadMoreLinkTextView.setOnClickListener(new OnClickListener() {
- @Override
- public void onClick(View v) {
- loadUrl(mUrl);
- RecordUserAction.record("MobileNTP.Snippets.Click");
- RecordHistogram.recordSparseSlowlyHistogram(
- "NewTabPage.Snippets.CardClicked", mPosition);
- RecordHistogram.recordEnumeratedHistogram(SnippetsManager.SNIPPETS_STATE_HISTOGRAM,
- SnippetsManager.SNIPPETS_CLICKED, SnippetsManager.NUM_SNIPPETS_ACTIONS);
- NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_SNIPPET);
- }
- });
- cardView.addOnAttachStateChangeListener(new View.OnAttachStateChangeListener() {
- @Override
- public void onViewAttachedToWindow(View v) {
- RecordHistogram.recordSparseSlowlyHistogram(
- "NewTabPage.Snippets.CardShown", mPosition);
- }
-
- @Override
- public void onViewDetachedFromWindow(View v) {}
- });
- }
-
- @Override
- public void onClick(View v) {
- // Toggle visibility of snippet text
- int visibility =
- (mArticleSnippetTextView.getVisibility() == View.GONE) ? View.VISIBLE : View.GONE;
- mArticleSnippetTextView.setVisibility(visibility);
- mReadMoreLinkTextView.setVisibility(visibility);
-
- String action = visibility == View.VISIBLE ? "MobileNTP.Snippets.ShowMore"
- : "MobileNTP.Snippets.ShowLess";
- String histogram = visibility == View.VISIBLE ? "NewTabPage.Snippets.CardExpanded"
- : "NewTabPage.Snippets.CardHidden";
- RecordUserAction.record(action);
- RecordHistogram.recordSparseSlowlyHistogram(histogram, mPosition);
- }
-
- @Override
- public void onBindViewHolder(SnippetListItem snippetItem) {
- SnippetArticle item = (SnippetArticle) snippetItem;
-
- mHeadlineTextView.setText(item.mTitle);
- mPublisherTextView.setText(item.mPublisher);
- mArticleSnippetTextView.setText(item.mPreviewText);
- mUrl = item.mUrl;
- mPosition = item.mPosition;
-
- item.setThumbnailOnView(mThumbnailView);
- }
-}

Powered by Google App Engine
This is Rietveld 408576698