Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + CR comments + added background color to new NTP Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml
diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
index b8f289313a570df14706fd0372550752286697bf..5189e5138af709640b76a4aa5e1f2a36d29c0e25 100644
--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
@@ -8,64 +8,53 @@
android:id="@+id/snippets_card_view"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:padding="16dp"
android:background="@drawable/bg_find_toolbar_popup">
-
+
<ImageView
android:id="@+id/article_thumbnail"
android:layout_width="@dimen/snippets_thumbnail_size"
android:layout_height="@dimen/snippets_thumbnail_size"
android:layout_alignParentTop="true"
- android:layout_alignParentStart="true"
+ android:layout_alignParentEnd="true"
+ android:layout_marginStart="16dp"
+ android:scaleType="centerCrop"
android:contentDescription="@null"
- android:padding="8dp"
android:src="@null"/>
-
+
<TextView
android:id="@+id/article_headline"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_toEndOf="@+id/article_thumbnail"
+ android:layout_alignParentStart="true"
+ android:layout_toStartOf="@+id/article_thumbnail"
android:maxLines="2"
- android:paddingTop="8dp"
- android:paddingStart="8dp"
- android:paddingEnd="8dp"
- android:textSize="18sp"
+ android:ellipsize="end"
+ android:textSize="16sp"
android:textColor="@color/snippets_headline_text_color" />
-
+
<TextView
- android:id="@+id/article_publisher"
+ android:id="@+id/article_snippet"
android:layout_width="match_parent"
android:layout_height="wrap_content"
+ android:layout_alignParentStart="true"
android:layout_below="@+id/article_headline"
- android:layout_toEndOf="@+id/article_thumbnail"
+ android:layout_toStartOf="@+id/article_thumbnail"
+ android:maxLines="2"
+ android:layout_marginTop="8dp"
android:ellipsize="end"
- android:maxLines="1"
- android:padding="8dp"
android:textSize="14sp"
- android:textColor="@color/snippets_publisher_name_color" />
-
+ android:textColor="@color/snippets_text_color" />
+
<TextView
- android:id="@+id/article_snippet"
+ android:id="@+id/article_publisher"
android:layout_width="match_parent"
android:layout_height="wrap_content"
- android:layout_alignParentStart="true"
- android:layout_below="@+id/article_thumbnail"
- android:padding="8dp"
- android:textSize="14sp"
- android:textColor="@color/snippets_text_color"
- android:visibility="gone" />
-
- <TextView
- android:id="@+id/read_more_link"
- android:layout_width="wrap_content"
- android:layout_height="wrap_content"
- android:layout_alignParentEnd="true"
android:layout_below="@+id/article_snippet"
- android:padding="16dp"
- android:text="@string/snippets_ntp_read_more_link_text"
- android:textAllCaps="true"
+ android:layout_toStartOf="@+id/article_thumbnail"
+ android:layout_marginTop="16dp"
+ android:maxLines="1"
+ android:ellipsize="end"
android:textSize="14sp"
- android:textColor="@color/snippets_read_more_link_color"
- android:visibility="gone" />
-
+ android:textColor="@color/snippets_publisher_name_color" />
</RelativeLayout>

Powered by Google App Engine
This is Rietveld 408576698