Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 1812293002: Add new NTP layout with snippet cards and hide it behind a flag (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase + CR comments + added background color to new NTP Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_scrollview.xml ('k') | chrome/android/java/res/values-sw600dp/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. --> 4 found in the LICENSE file. -->
5 5
6 <RelativeLayout 6 <RelativeLayout
7 xmlns:android="http://schemas.android.com/apk/res/android" 7 xmlns:android="http://schemas.android.com/apk/res/android"
8 android:id="@+id/snippets_card_view" 8 android:id="@+id/snippets_card_view"
9 android:layout_width="match_parent" 9 android:layout_width="match_parent"
10 android:layout_height="wrap_content" 10 android:layout_height="wrap_content"
11 android:padding="16dp"
11 android:background="@drawable/bg_find_toolbar_popup"> 12 android:background="@drawable/bg_find_toolbar_popup">
12 13
13 <ImageView 14 <ImageView
14 android:id="@+id/article_thumbnail" 15 android:id="@+id/article_thumbnail"
15 android:layout_width="@dimen/snippets_thumbnail_size" 16 android:layout_width="@dimen/snippets_thumbnail_size"
16 android:layout_height="@dimen/snippets_thumbnail_size" 17 android:layout_height="@dimen/snippets_thumbnail_size"
17 android:layout_alignParentTop="true" 18 android:layout_alignParentTop="true"
18 android:layout_alignParentStart="true" 19 android:layout_alignParentEnd="true"
20 android:layout_marginStart="16dp"
21 android:scaleType="centerCrop"
19 android:contentDescription="@null" 22 android:contentDescription="@null"
20 android:padding="8dp"
21 android:src="@null"/> 23 android:src="@null"/>
22 24
23 <TextView 25 <TextView
24 android:id="@+id/article_headline" 26 android:id="@+id/article_headline"
25 android:layout_width="match_parent" 27 android:layout_width="match_parent"
26 android:layout_height="wrap_content" 28 android:layout_height="wrap_content"
27 android:layout_toEndOf="@+id/article_thumbnail" 29 android:layout_alignParentStart="true"
30 android:layout_toStartOf="@+id/article_thumbnail"
28 android:maxLines="2" 31 android:maxLines="2"
29 android:paddingTop="8dp" 32 android:ellipsize="end"
30 android:paddingStart="8dp" 33 android:textSize="16sp"
31 android:paddingEnd="8dp"
32 android:textSize="18sp"
33 android:textColor="@color/snippets_headline_text_color" /> 34 android:textColor="@color/snippets_headline_text_color" />
34 35
35 <TextView
36 android:id="@+id/article_publisher"
37 android:layout_width="match_parent"
38 android:layout_height="wrap_content"
39 android:layout_below="@+id/article_headline"
40 android:layout_toEndOf="@+id/article_thumbnail"
41 android:ellipsize="end"
42 android:maxLines="1"
43 android:padding="8dp"
44 android:textSize="14sp"
45 android:textColor="@color/snippets_publisher_name_color" />
46
47 <TextView 36 <TextView
48 android:id="@+id/article_snippet" 37 android:id="@+id/article_snippet"
49 android:layout_width="match_parent" 38 android:layout_width="match_parent"
50 android:layout_height="wrap_content" 39 android:layout_height="wrap_content"
51 android:layout_alignParentStart="true" 40 android:layout_alignParentStart="true"
52 android:layout_below="@+id/article_thumbnail" 41 android:layout_below="@+id/article_headline"
53 android:padding="8dp" 42 android:layout_toStartOf="@+id/article_thumbnail"
43 android:maxLines="2"
44 android:layout_marginTop="8dp"
45 android:ellipsize="end"
54 android:textSize="14sp" 46 android:textSize="14sp"
55 android:textColor="@color/snippets_text_color" 47 android:textColor="@color/snippets_text_color" />
56 android:visibility="gone" /> 48
57 49 <TextView
58 <TextView 50 android:id="@+id/article_publisher"
59 android:id="@+id/read_more_link" 51 android:layout_width="match_parent"
60 android:layout_width="wrap_content"
61 android:layout_height="wrap_content" 52 android:layout_height="wrap_content"
62 android:layout_alignParentEnd="true"
63 android:layout_below="@+id/article_snippet" 53 android:layout_below="@+id/article_snippet"
64 android:padding="16dp" 54 android:layout_toStartOf="@+id/article_thumbnail"
65 android:text="@string/snippets_ntp_read_more_link_text" 55 android:layout_marginTop="16dp"
66 android:textAllCaps="true" 56 android:maxLines="1"
57 android:ellipsize="end"
67 android:textSize="14sp" 58 android:textSize="14sp"
68 android:textColor="@color/snippets_read_more_link_color" 59 android:textColor="@color/snippets_publisher_name_color" />
69 android:visibility="gone" />
70
71 </RelativeLayout> 60 </RelativeLayout>
OLDNEW
« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_scrollview.xml ('k') | chrome/android/java/res/values-sw600dp/dimens.xml » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java » ('J')

Powered by Google App Engine
This is Rietveld 408576698