third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp - Issue 1812273003: Eliminate copies of encoded image data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix assertion Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/DataSegmentReader.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.h ('k') | third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp » ('j') | third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReaderTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp b/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

index 63a380a34bced9cbb5bace6ab5820c07a60df9b1..ba2f23909aa8cb1a3f65893873b553fde72ab85d 100644

--- a/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/FastSharedBufferReader.cpp

@@ -32,7 +32,7 @@

namespace blink {

-FastSharedBufferReader::FastSharedBufferReader(PassRefPtr<SharedBuffer> data)

+FastSharedBufferReader::FastSharedBufferReader(PassRefPtr<SegmentReader> data)

: m_data(data)

, m_segment(0)

, m_segmentLength(0)

@@ -40,7 +40,7 @@ FastSharedBufferReader::FastSharedBufferReader(PassRefPtr<SharedBuffer> data)

{

}

-void FastSharedBufferReader::setData(PassRefPtr<SharedBuffer> data)

+void FastSharedBufferReader::setData(PassRefPtr<SegmentReader> data)

{

if (data == m_data)

return;