Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/DataSegmentReader.cpp

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix assertion Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/DataSegmentReader.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/DataSegmentReader.cpp b/third_party/WebKit/Source/platform/image-decoders/DataSegmentReader.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..e846ee2b78becd1d316a38321c6279c679902a9d
--- /dev/null
+++ b/third_party/WebKit/Source/platform/image-decoders/DataSegmentReader.cpp
@@ -0,0 +1,54 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "platform/image-decoders/SegmentReader.h"
+
+#include "third_party/skia/include/core/SkData.h"
+#include "wtf/Noncopyable.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefPtr.h"
+
+namespace blink {
+
+// Interface for ImageDecoder to read an SkData
Peter Kasting 2016/03/25 06:24:36 Nit: Trailing period
scroggo 2016/03/25 15:49:53 Done.
+class DataSegmentReader final : public SegmentReader {
+ WTF_MAKE_NONCOPYABLE(DataSegmentReader);
+public:
+ DataSegmentReader(PassRefPtr<SkData>);
+ size_t size() const override;
+ size_t getSomeData(const char*& data, size_t position) const override;
+ PassRefPtr<SkData> getAsSkData() const override;
+private:
+ RefPtr<SkData> m_data;
+};
+
+PassRefPtr<SegmentReader> SegmentReader::createFromSkData(PassRefPtr<SkData> data)
+{
+ return adoptRef(new DataSegmentReader(data));
+}
+
+DataSegmentReader::DataSegmentReader(PassRefPtr<SkData> data)
+: m_data(data) {}
Peter Kasting 2016/03/25 06:24:36 Nit: Indent 4
scroggo 2016/03/25 15:49:53 Done.
+
+size_t DataSegmentReader::size() const
+{
+ return m_data->size();
+}
+
+size_t DataSegmentReader::getSomeData(const char*& data, size_t position) const
+{
+ if (position >= m_data->size())
+ return 0;
+
+ data = reinterpret_cast<const char*>(m_data->bytes() + position);
+ return m_data->size() - position;
+}
+
+PassRefPtr<SkData> DataSegmentReader::getAsSkData() const
+{
+ return m_data.get();
+}
+
+} // namespace blink
+

Powered by Google App Engine
This is Rietveld 408576698