Eliminate copies of encoded image data

third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoder.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 12 matching lines @@
  * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
  * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
  * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef WEBPImageDecoder_h
 #define WEBPImageDecoder_h
 
 #include "platform/image-decoders/ImageDecoder.h"
+#include "skia/ext/refptr.h"

[f(malita), 2016/03/23 16:41:58]

wtf/RefPtr.h

[scroggo_chromium, 2016/03/24 13:59:46]

Done.

+#include "third_party/skia/include/core/SkData.h"
 #include "webp/decode.h"
 #include "webp/demux.h"
 
 namespace blink {
 
 class PLATFORM_EXPORT WEBPImageDecoder final : public ImageDecoder {
     WTF_MAKE_NONCOPYABLE(WEBPImageDecoder);
 public:
     WEBPImageDecoder(AlphaOption, GammaAndColorProfileOption, size_t maxDecodedBytes);
     ~WEBPImageDecoder() override;
 
     // ImageDecoder:
     String filenameExtension() const override { return "webp"; }
     bool hasColorProfile() const override { return m_hasColorProfile; }
-    void onSetData(SharedBuffer* data) override;
+    void onSetData(SegmentReader* data) override;
     int repetitionCount() const override;
     bool frameIsCompleteAtIndex(size_t) const override;
     float frameDurationAtIndex(size_t) const override;
     size_t clearCacheExceptFrame(size_t) override;
 
 private:
     // ImageDecoder:
     virtual void decodeSize() { updateDemuxer(); }
     size_t decodeFrameCount() override;
     void initializeNewFrame(size_t) override;
@@ skipping 25 matching lines @@
     WebPDemuxState m_demuxState;
     bool m_haveAlreadyParsedThisData;
     int m_repetitionCount;
     int m_decodedHeight;
 
     typedef void (*AlphaBlendFunction)(ImageFrame&, ImageFrame&, int, int, int);
     AlphaBlendFunction m_blendFunction;
 
     void clear();
     void clearDecoder();
+
+    // FIXME: Update libwebp's API so it does not require copying the data on each update.
+    skia::RefPtr<SkData> m_encodedData;

[f(malita), 2016/03/23 16:41:58]

RefPtr<SkData>

[scroggo_chromium, 2016/03/24 13:59:46]

Done.

 };
 
 } // namespace blink
 
 #endif