Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp

Issue 1812273003: Eliminate copies of encoded image data (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
diff --git a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
index 9f2c660ff300aca73abfdf6e331845256eefefc4..f930315da3da092827e3604422b39dfa679ac664 100644
--- a/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
+++ b/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
@@ -33,6 +33,7 @@
#include "platform/SharedBuffer.h"
#include "platform/image-decoders/ImageAnimation.h"
#include "platform/image-decoders/ImageDecoderTestHelpers.h"
+#include "platform/image-decoders/SharedBufferSegmentReader.h"
#include "public/platform/WebData.h"
#include "public/platform/WebSize.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -63,7 +64,8 @@ void downsample(size_t maxDecodedBytes, unsigned* outputWidth, unsigned* outputH
ASSERT_TRUE(data);
OwnPtr<ImageDecoder> decoder = createDecoder(maxDecodedBytes);
- decoder->setData(data.get(), true);
+ RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferSegmentReader(data));
+ decoder->setData(segmentReader.get(), true);
ImageFrame* frame = decoder->frameBufferAtIndex(0);
ASSERT_TRUE(frame);
@@ -78,7 +80,8 @@ void readYUV(size_t maxDecodedBytes, unsigned* outputYWidth, unsigned* outputYHe
ASSERT_TRUE(data);
OwnPtr<ImageDecoder> decoder = createDecoder(maxDecodedBytes);
- decoder->setData(data.get(), true);
+ RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferSegmentReader(data));
+ decoder->setData(segmentReader.get(), true);
OwnPtr<ImagePlanes> imagePlanes = adoptPtr(new ImagePlanes());
decoder->setImagePlanes(imagePlanes.release());
@@ -222,7 +225,8 @@ TEST(JPEGImageDecoderTest, yuv)
ASSERT_TRUE(data);
OwnPtr<ImageDecoder> decoder = createDecoder(230 * 230 * 4);
- decoder->setData(data.get(), true);
+ RefPtr<SharedBufferSegmentReader> segmentReader = adoptRef(new SharedBufferSegmentReader(data));
+ decoder->setData(segmentReader.get(), true);
OwnPtr<ImagePlanes> imagePlanes = adoptPtr(new ImagePlanes());
decoder->setImagePlanes(imagePlanes.release());

Powered by Google App Engine
This is Rietveld 408576698