[Offline pages] Minimizing exposure to ChromeActivity in offline pages

[Offline pages] Minimizing exposure to ChromeActivity in offline pages

Offline pages rely heavily on ChromeActivity in functions that show
a snackbar. In order to enable coverage of that functionality with
junit, we need to minimize exposure to ChromeActivity, which cannot
be currently mocked.

BUG=594252
Committed: https://crrev.com/198ef342ac9036f0a05bcebf111ee5756eb7b78b
Cr-Commit-Position: refs/heads/master@{#382424}

[fgorski, 2016-03-18 22:57:39]

Description was changed from

==========
[Offline pages] Minimizing exposure to ChromeActivity in offline pages

Offline pages rely heavily on ChromeActivity in functions that show
a snackbar. In order to enable coverage of that functionality with
junit, we need to minimize exposure to ChromeActivity, which cannot
be currently mocked.

BUG=594252
==========

to

==========
[Offline pages] Minimizing exposure to ChromeActivity in offline pages

Offline pages rely heavily on ChromeActivity in functions that show
a snackbar. In order to enable coverage of that functionality with
junit, we need to minimize exposure to ChromeActivity, which cannot
be currently mocked.

BUG=594252
==========

[fgorski, 2016-03-18 22:57:39]

fgorski@chromium.org changed reviewers:
+ petewil@chromium.org

[fgorski, 2016-03-18 22:57:50]

take a look, please

[Pete Williamson, 2016-03-21 17:02:40]

lgtm

[fgorski, 2016-03-21 20:48:02]

New patch only updates the javadoc.

[fgorski, 2016-03-21 22:02:07]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2016-03-21 22:02:07]

The patchset sent to the CQ was uploaded after l-g-t-m from petewil@chromium.org
Link to the patchset: https://codereview.chromium.org/1812103004/#ps40001
(title: "Removing bookmark id from offline page tab observer")

[commit-bot: I haz the power, 2016-03-21 22:02:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1812103004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1812103004/40001

[commit-bot: I haz the power, 2016-03-21 22:50:32]

Description was changed from

==========
[Offline pages] Minimizing exposure to ChromeActivity in offline pages

Offline pages rely heavily on ChromeActivity in functions that show
a snackbar. In order to enable coverage of that functionality with
junit, we need to minimize exposure to ChromeActivity, which cannot
be currently mocked.

BUG=594252
==========

to

==========
[Offline pages] Minimizing exposure to ChromeActivity in offline pages

Offline pages rely heavily on ChromeActivity in functions that show
a snackbar. In order to enable coverage of that functionality with
junit, we need to minimize exposure to ChromeActivity, which cannot
be currently mocked.

BUG=594252
==========

[commit-bot: I haz the power, 2016-03-21 22:50:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-21 22:52:32]

Description was changed from

==========
[Offline pages] Minimizing exposure to ChromeActivity in offline pages

Offline pages rely heavily on ChromeActivity in functions that show
a snackbar. In order to enable coverage of that functionality with
junit, we need to minimize exposure to ChromeActivity, which cannot
be currently mocked.

BUG=594252
==========

to

==========
[Offline pages] Minimizing exposure to ChromeActivity in offline pages

Offline pages rely heavily on ChromeActivity in functions that show
a snackbar. In order to enable coverage of that functionality with
junit, we need to minimize exposure to ChromeActivity, which cannot
be currently mocked.

BUG=594252

Committed: https://crrev.com/198ef342ac9036f0a05bcebf111ee5756eb7b78b
Cr-Commit-Position: refs/heads/master@{#382424}
==========

[commit-bot: I haz the power, 2016-03-21 22:52:33]

Patchset 3 (id:??) landed as
https://crrev.com/198ef342ac9036f0a05bcebf111ee5756eb7b78b
Cr-Commit-Position: refs/heads/master@{#382424}