Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java

Issue 1812103004: [Offline pages] Minimizing exposure to ChromeActivity in offline pages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removing bookmark id from offline page tab observer Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java
index 38514fd89d304bad5aa17da5721a5f7233147472..af1ffaeadfddb6f0324a3791c4d6deab1dcba3c4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageConnectivityListener.java
@@ -4,8 +4,10 @@
package org.chromium.chrome.browser.offlinepages;
+import android.content.Context;
+
import org.chromium.base.Log;
-import org.chromium.chrome.browser.ChromeActivity;
+import org.chromium.chrome.browser.snackbar.SnackbarManager;
import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarController;
import org.chromium.chrome.browser.tab.Tab;
import org.chromium.net.NetworkChangeNotifier;
@@ -16,20 +18,24 @@ import org.chromium.net.NetworkChangeNotifier;
public class OfflinePageConnectivityListener
implements NetworkChangeNotifier.ConnectionTypeObserver {
private static final String TAG = "OfflinePageCL";
+ private Context mContext;
+ private SnackbarManager mSnackbarManager;
private Tab mTab;
- private ChromeActivity mActivity;
private boolean mSeen;
private boolean mEnabled;
private SnackbarController mSnackbarController;
/**
* Builds an offline page connectivity listener.
- * @param activity The ChromeActivity that we are listening for.
+ * @param context android context
+ * @param snackbarManager The snackbar manager to show and dismiss snackbars.
* @param tab The current tab that we are setting up a listener for.
+ * @param snackbarController The snackbar controller to control snackbar behavior.
*/
- public OfflinePageConnectivityListener(
- ChromeActivity activity, Tab tab, SnackbarController snackbarController) {
- this.mActivity = activity;
+ public OfflinePageConnectivityListener(Context context, SnackbarManager snackbarManager,
+ Tab tab, SnackbarController snackbarController) {
+ this.mContext = context;
+ this.mSnackbarManager = snackbarManager;
this.mTab = tab;
this.mSeen = false;
this.mEnabled = false;
@@ -53,7 +59,8 @@ public class OfflinePageConnectivityListener
// several seconds.
if (connected && mTab != null && !mSeen) {
Log.d(TAG, "Connection became available, show reload snackbar.");
- OfflinePageUtils.showOfflineSnackbarIfNecessary(mActivity, mTab, mSnackbarController);
+ OfflinePageUtils.showOfflineSnackbarIfNecessary(
+ mContext, mSnackbarManager, mTab, mSnackbarController);
// We can stop listening for online transitions once we go online.
disable();
mSeen = true;
@@ -62,6 +69,7 @@ public class OfflinePageConnectivityListener
/**
* Enable the listener when we have an offline page showing.
+ * @param snackbarController The snackbar controller to control snackbar behavior.
*/
public void enable(SnackbarController snackbarController) {
if (!mEnabled) {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageTabObserver.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698