mus: Allow SetModal to fail gracefully

mus: Allow SetModal to fail gracefully

Mus server might prevent some windows from becoming system modals. In
this case, SetModal would fail and the client needs to handle the
failure and revert the modality set locally for the window.

BUG=548402
Committed: https://crrev.com/4d450a137fdf54b674045d5abf788dd394315eb6
Cr-Commit-Position: refs/heads/master@{#381871}

[mohsen, 2016-03-17 18:13:15]

mohsen@chromium.org changed reviewers:
+ sky@chromium.org

[mohsen, 2016-03-17 18:13:16]

Please take a look...

[mohsen, 2016-03-17 18:13:50]

Description was changed from

==========
mus: Allow SetModal to fail gracefully

Mus server might prevent some windows from becoming system modals. In
this case, SetModal would fail and the client needs to handle the
failure and revert the local modality set for the window.

BUG=548402
==========

to

==========
mus: Allow SetModal to fail gracefully

Mus server might prevent some windows from becoming system modals. In
this case, SetModal would fail and the client needs to handle the
failure and revert the modality set locally for the window.

BUG=548402
==========

[sky, 2016-03-17 22:59:42]

LGTM

https://codereview.chromium.org/1811913004/diff/1/components/mus/public/cpp/l...
File components/mus/public/cpp/lib/in_flight_change.h (right):

https://codereview.chromium.org/1811913004/diff/1/components/mus/public/cpp/l...
components/mus/public/cpp/lib/in_flight_change.h:269:
InFlightSetModalChange(Window* window);
explicit, and don't have the compiler generate destructor.

[mohsen, 2016-03-17 23:51:31]

https://codereview.chromium.org/1811913004/diff/1/components/mus/public/cpp/l...
File components/mus/public/cpp/lib/in_flight_change.h (right):

https://codereview.chromium.org/1811913004/diff/1/components/mus/public/cpp/l...
components/mus/public/cpp/lib/in_flight_change.h:269:
InFlightSetModalChange(Window* window);
On 2016/03/17 at 22:59:42, sky wrote:
> explicit, and don't have the compiler generate destructor.

Done. Also added destructor for InFlightVisibleChange.

[mohsen, 2016-03-18 02:07:30]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2016-03-18 02:07:31]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1811913004/#ps20001
(title: "Fixed constructor/destructor")

[commit-bot: I haz the power, 2016-03-18 02:07:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811913004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811913004/20001

[commit-bot: I haz the power, 2016-03-18 02:12:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-18 02:14:36]

Description was changed from

==========
mus: Allow SetModal to fail gracefully

Mus server might prevent some windows from becoming system modals. In
this case, SetModal would fail and the client needs to handle the
failure and revert the modality set locally for the window.

BUG=548402
==========

to

==========
mus: Allow SetModal to fail gracefully

Mus server might prevent some windows from becoming system modals. In
this case, SetModal would fail and the client needs to handle the
failure and revert the modality set locally for the window.

BUG=548402

Committed: https://crrev.com/4d450a137fdf54b674045d5abf788dd394315eb6
Cr-Commit-Position: refs/heads/master@{#381871}
==========

[commit-bot: I haz the power, 2016-03-18 02:14:37]

Patchset 2 (id:??) landed as
https://crrev.com/4d450a137fdf54b674045d5abf788dd394315eb6
Cr-Commit-Position: refs/heads/master@{#381871}