components/mus/public/cpp/lib/window_tree_client_impl.cc - Issue 1811913004: mus: Allow SetModal to fail gracefully

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/mus/public/cpp/lib/window_tree_client_impl.cc

Issue 1811913004: mus: Allow SetModal to fail gracefully (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed constructor/destructor Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/mus/public/cpp/lib/window_tree_client_impl.cc

diff --git a/components/mus/public/cpp/lib/window_tree_client_impl.cc b/components/mus/public/cpp/lib/window_tree_client_impl.cc

index 5c28a568dd284e1e5dd8b677c1f4dd5eb2b9c658..84ed6702ca4df6ba4976d87910844b747b2959f6 100644

--- a/components/mus/public/cpp/lib/window_tree_client_impl.cc

+++ b/components/mus/public/cpp/lib/window_tree_client_impl.cc

@@ -219,7 +219,7 @@ void WindowTreeClientImpl::RemoveTransientWindowFromParent(Window* window) {

void WindowTreeClientImpl::SetModal(Window* window) {

DCHECK(tree_);

const uint32_t change_id = ScheduleInFlightChange(

- make_scoped_ptr(new CrashInFlightChange(window, ChangeType::SET_MODAL)));

+ make_scoped_ptr(new InFlightSetModalChange(window)));

tree_->SetModal(change_id, window->id());

}