Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1811773002: DevTools: Use live location for line level profile presentation. (Closed)

Created:
4 years, 9 months ago by alph
Modified:
4 years, 9 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use live location for line level profile presentation. BUG=590936 Committed: https://crrev.com/ab1bb29984068b61637741beaa03fc50a91c17dc Cr-Commit-Position: refs/heads/master@{#382738}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressing comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -14 lines) Patch
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 1 chunk +11 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 2 chunks +29 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 1 2 chunks +28 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
alph
4 years, 9 months ago (2016-03-16 23:28:44 UTC) #2
pfeldman
lgtm https://codereview.chromium.org/1811773002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/1811773002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode1294 third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1294: var uiLocation = liveLocation.uiLocation(); remove them from the ...
4 years, 9 months ago (2016-03-17 01:20:58 UTC) #3
alph
ptal https://codereview.chromium.org/1811773002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js (right): https://codereview.chromium.org/1811773002/diff/1/third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js#newcode1294 third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1294: var uiLocation = liveLocation.uiLocation(); On 2016/03/17 01:20:58, pfeldman ...
4 years, 9 months ago (2016-03-22 21:41:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811773002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811773002/20001
4 years, 9 months ago (2016-03-22 21:42:49 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 00:06:28 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 00:07:34 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ab1bb29984068b61637741beaa03fc50a91c17dc
Cr-Commit-Position: refs/heads/master@{#382738}

Powered by Google App Engine
This is Rietveld 408576698