third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js - Issue 1811773002: DevTools: Use live location for line level profile presentation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

Issue 1811773002: DevTools: Use live location for line level profile presentation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing comments. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

index 1f67829867ca33c0cebc0baf69a55a89c793099d..243d057d79834602f0f36a6df00a9730123f2855 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineModel.js

@@ -1761,7 +1761,7 @@ WebInspector.TimelineModel.LineLevelProfile.prototype = {

}

for (var j = 0; j < node.positionTicks.length; ++j) {

var lineInfo = node.positionTicks[j];

- var line = lineInfo.line - 1;

+ var line = lineInfo.line;

var time = lineInfo.ticks * sampleDuration;

fileInfo.set(line, (fileInfo.get(line) || 0) + time);

}

« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js » ('j') | no next file with comments »