Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 1811743002: Re-land: Enable XFA-Forms for the PDFium plugin. (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Enable XFA-Forms for the PDFium plugin. This reverts commit 13fe4645b7199ed2da4f1810d4c96262eaecea5f. See https://codereview.chromium.org/1761673002/ TBR=thakis@chromium.org Committed: https://crrev.com/ed07b3773e3aad4a44a79a48c17162ef57ca82ee Cr-Commit-Position: refs/heads/master@{#381573}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M build/common.gypi View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Tom Sepez
Third try.
4 years, 9 months ago (2016-03-16 21:32:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811743002/1
4 years, 9 months ago (2016-03-16 21:33:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 22:53:43 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ed07b3773e3aad4a44a79a48c17162ef57ca82ee Cr-Commit-Position: refs/heads/master@{#381573}
4 years, 9 months ago (2016-03-16 22:54:59 UTC) #9
stevenjb
On 2016/03/16 22:54:59, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 9 months ago (2016-03-17 18:37:53 UTC) #10
stevenjb
On 2016/03/17 18:37:53, stevenjb wrote: > On 2016/03/16 22:54:59, commit-bot: I haz the power wrote: ...
4 years, 9 months ago (2016-03-17 18:55:39 UTC) #11
stevenjb
4 years, 9 months ago (2016-03-17 18:58:23 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1814843003/ by stevenjb@chromium.org.

The reason for reverting is: Causing "Target image has run out of space" errors
on Chrome OS builders:

http://crbug.com/595763
.

Powered by Google App Engine
This is Rietveld 408576698