Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1784113002: Revert of Re-land: Enable XFA-Forms for the PDFium plugin. (Closed)

Created:
4 years, 9 months ago by shinyak
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-land: Enable XFA-Forms for the PDFium plugin. (patchset #1 id:1 of https://codereview.chromium.org/1775173002/ ) Reason for revert: Speculative revert for too long compile time Original issue's description: > Re-land: Enable XFA-Forms for the PDFium plugin. > > This is a change to gather stability, performance, and size > data and will be rolled back by 2016-03-18. > > This is the gyp portion of the change; the GN variables > controlling the same things currently reside in the pdfium > product itsef. > > Original Review URL: https://codereview.chromium.org/1761673002 > > Cr-Commit-Position: refs/heads/master@{#379622} > (cherry picked from commit afa43e7fa9754cff9ceb6969c665830a79a84c5b) > > Committed: https://crrev.com/1e379580207e1bc923773ed8cf2f2fa9cc020394 > Cr-Commit-Position: refs/heads/master@{#380444} TBR=thakis@chromium.org,tsepez@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/13fe4645b7199ed2da4f1810d4c96262eaecea5f Cr-Commit-Position: refs/heads/master@{#380508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M build/common.gypi View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
shinyak
Created Revert of Re-land: Enable XFA-Forms for the PDFium plugin.
4 years, 9 months ago (2016-03-11 02:53:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1784113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1784113002/1
4 years, 9 months ago (2016-03-11 02:53:37 UTC) #2
shinyak
4 years, 9 months ago (2016-03-11 02:53:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-11 02:54:04 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/13fe4645b7199ed2da4f1810d4c96262eaecea5f Cr-Commit-Position: refs/heads/master@{#380508}
4 years, 9 months ago (2016-03-11 02:55:25 UTC) #6
stevenjb
On 2016/03/11 02:55:25, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 9 months ago (2016-03-11 19:05:27 UTC) #7
stevenjb
On 2016/03/11 19:05:27, stevenjb wrote: > On 2016/03/11 02:55:25, commit-bot: I haz the power wrote: ...
4 years, 9 months ago (2016-03-11 19:19:39 UTC) #8
Nico
Huh, interesting. Chrome-on-ChromeOS doesn't use clang, right?
4 years, 9 months ago (2016-03-11 19:38:04 UTC) #9
Nico
4 years, 9 months ago (2016-03-11 19:38:51 UTC) #10
Message was sent while issue was closed.
On 2016/03/11 19:38:04, Nico wrote:
> Huh, interesting. Chrome-on-ChromeOS doesn't use clang, right?

...actually, that bot probably does. So that might be a known problem caused by
a combination of this change + clang roll, and reverting the clang roll instead
of XFA might help too. I will look into that later today.

Powered by Google App Engine
This is Rietveld 408576698