src/core/SkDrawable.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkDrawable.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkDrawable.cpp

diff --git a/src/core/SkDrawable.cpp b/src/core/SkDrawable.cpp

index 8fea38be34a46cf3f1ea820d558039b795195ff5..bf6d39cfca53f6bf73c43c6c60e94ded70661e84 100644

--- a/src/core/SkDrawable.cpp

+++ b/src/core/SkDrawable.cpp

@@ -81,5 +81,5 @@ SkPicture* SkDrawable::onNewPictureSnapshot() {

if (false) {

draw_bbox(canvas, bounds);

}

- return recorder.endRecording();

+ return recorder.finishRecordingAsPicture().release();

}

« no previous file with comments | « src/c/sk_surface.cpp ('k') | src/core/SkMiniRecorder.cpp » ('j') | no next file with comments »