src/c/sk_surface.cpp - Issue 1811703002: return pictures as sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/c/sk_surface.cpp

Issue 1811703002: return pictures as sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rely on RVO in picturerecorder Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/c/sk_surface.cpp

diff --git a/src/c/sk_surface.cpp b/src/c/sk_surface.cpp

index 79036f75fe88a8f44092af2b65a214f5f4d7a002..75a1643775fd26387c1e8c22d4c53fc7c82f8305 100644

--- a/src/c/sk_surface.cpp

+++ b/src/c/sk_surface.cpp

@@ -482,7 +482,7 @@ sk_canvas_t* sk_picture_recorder_begin_recording(sk_picture_recorder_t* crec,

}

sk_picture_t* sk_picture_recorder_end_recording(sk_picture_recorder_t* crec) {

- return ToPicture(AsPictureRecorder(crec)->endRecording());

+ return ToPicture(AsPictureRecorder(crec)->finishRecordingAsPicture().release());

}

void sk_picture_ref(sk_picture_t* cpic) {

« no previous file with comments | « samplecode/SampleTiling.cpp ('k') | src/core/SkDrawable.cpp » ('j') | no next file with comments »