Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: src/compiler.cc

Issue 1811553003: [Interpreter] Make ignition compiler eagerly. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix tests Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 3d6805d88fbdc9f2b027940806328b8169fb2a8f..809a1b30a7bc8e6a43b3da73438357b920eeeeba 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -1275,6 +1275,9 @@ Handle<SharedFunctionInfo> CompileToplevel(CompilationInfo* info) {
// Consider parsing eagerly when targeting the code cache.
parse_allow_lazy &= !(FLAG_serialize_eager && info->will_serialize());
+ // Consider parsing eagerly when targeting Ignition.
+ parse_allow_lazy &= !(FLAG_ignition && !isolate->serializer_enabled());
+
parse_info->set_allow_lazy_parsing(parse_allow_lazy);
if (!parse_allow_lazy &&
(options == ScriptCompiler::kProduceParserCache ||
@@ -1790,6 +1793,9 @@ Handle<SharedFunctionInfo> Compiler::GetSharedFunctionInfo(
// Consider compiling eagerly when targeting the code cache.
lazy &= !(FLAG_serialize_eager && info.will_serialize());
+ // Consider compiling eagerly when compiling bytecode for Ignition.
+ lazy &= !(FLAG_ignition && !isolate->serializer_enabled());
+
// Generate code
TimerEventScope<TimerEventCompileCode> timer(isolate);
TRACE_EVENT0("v8", "V8.CompileCode");

Powered by Google App Engine
This is Rietveld 408576698