[Interpreter] Make ignition compiler eagerly.

src/background-parsing-task.cc

Index: src/background-parsing-task.cc
diff --git a/src/background-parsing-task.cc b/src/background-parsing-task.cc
index cc80e0114319a7af442123aea05cbace4ead89a2..2404f85ba03a02b94cc1b4072bcbb94b7ff66056 100644
--- a/src/background-parsing-task.cc
+++ b/src/background-parsing-task.cc
@@ -32,7 +32,8 @@ BackgroundParsingTask::BackgroundParsingTask(
   info->set_global();
   info->set_unicode_cache(&source_->unicode_cache);
   info->set_compile_options(options);
-  info->set_allow_lazy_parsing(true);
+  // Parse eagerly with ignition since we will compile eagerly.
+  info->set_allow_lazy_parsing(!FLAG_ignition);

[rmcilroy, 2016/03/22 15:43:25]

Yang - I was getting crashes for certain tests before changing this due to the
background parser not parsing eagerly, but Ignition trying to compile eagerly
(on functions with no parse data). I'm not sure if you would ever see the same
with your changes to eagerly compile functions when building a code snapshot -
would V8 ever use the background parser and then try and compile eagerly with
your change?

[Yang, 2016/03/23 14:29:11]

The code snapshot never runs into the issue with the background parser because
we only ever serialize on second compile. Which loads the source from cache, and
doesn't stream it from network.

Not too familiar with this part of the code :/

[rmcilroy, 2016/03/24 11:30:45]

Yeah makes sense, just checking.

 }