Have PNaCl use debug pexe URL instead of stripped pexe w/ kEnableNaClDebug

Have PNaCl use debug pexe URL instead of stripped pexe w/ kEnableNaClDebug

Debug metadata is not part of the PNaCl stable bitcode format
so is stripped before deployment. In order to make debugging
easier (no separate translation), allow a separate debug URL
in the NMF file which can point to the unstripped
LLVM-formatted pexe which should still have debug metadata.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3765
TEST=browser_tests --gtest_filter=*PnaclDebugURL

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254212

R=bradnelson@chromium.org, bradnelson@google.com, dmichael@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255499

[bradn, 2014-02-26 18:38:43]

- The title seems to suggest that the normal URL will be a debug url, but that's
not the case correct?

- Is it useful to add an additional flag that forces the regular url to be
debuggable as well? (ie so you can debug something without haven't to change the
page)

[bradn, 2014-02-27 00:14:41]

LGTM, but could we add a test of the fallback in the case where debugging is in
the nmf, but not turned on?

https://codereview.chromium.org/181153002/diff/40001/chrome/test/data/nacl/pn...
File chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html (right):

https://codereview.chromium.org/181153002/diff/40001/chrome/test/data/nacl/pn...
chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html:51: // non-debug one
and succeed.
So it seems like this should do the debug url if debugging is enabled, but fall
back to the non-debug one in the case where it isn't?

https://codereview.chromium.org/181153002/diff/40001/chrome/test/nacl/nacl_br...
File chrome/test/nacl/nacl_browsertest.cc (right):

https://codereview.chromium.org/181153002/diff/40001/chrome/test/nacl/nacl_br...
chrome/test/nacl/nacl_browsertest.cc:196: // Turn on debugging to influence the
PNaCl URL loaded
Can we do a test with debug on and off?

https://codereview.chromium.org/181153002/diff/40001/ppapi/native_client/src/...
File ppapi/native_client/src/trusted/plugin/json_manifest.cc (right):

https://codereview.chromium.org/181153002/diff/40001/ppapi/native_client/src/...
ppapi/native_client/src/trusted/plugin/json_manifest.cc:520:
GrabUrlAndPnaclOptions(isa_spec[kPnaclDebugKey], url, pnacl_options);
Ah ok, it does. Sounds good.

[jvoung (off chromium), 2014-02-27 23:06:36]

-teravest since he is out until next week
+dmichael for PPAPI OWNERS review

https://codereview.chromium.org/181153002/diff/40001/chrome/test/data/nacl/pn...
File chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html (right):

https://codereview.chromium.org/181153002/diff/40001/chrome/test/data/nacl/pn...
chrome/test/data/nacl/pnacl_debug_url/pnacl_debug_url.html:51: // non-debug one
and succeed.
On 2014/02/27 00:14:42, bradn wrote:
> So it seems like this should do the debug url if debugging is enabled, but
fall
> back to the non-debug one in the case where it isn't?

Added a test where the manifest has both choices, but the browser is launched
w/out debug flags.

https://codereview.chromium.org/181153002/diff/40001/chrome/test/nacl/nacl_br...
File chrome/test/nacl/nacl_browsertest.cc (right):

https://codereview.chromium.org/181153002/diff/40001/chrome/test/nacl/nacl_br...
chrome/test/nacl/nacl_browsertest.cc:196: // Turn on debugging to influence the
PNaCl URL loaded
On 2014/02/27 00:14:42, bradn wrote:
> Can we do a test with debug on and off?

Done.

[dmichael (off chromium), 2014-02-27 23:31:19]

ppapi lgtm

[bradn, 2014-02-27 23:38:42]

Still LGTM

[jvoung (off chromium), 2014-02-28 00:10:15]

On 2014/02/27 23:38:42, bradn wrote:
> Still LGTM

Thanks Brad, but I think your chromium account is the one under OWNERS?

Also, the main discussion w/ the SDK right now is with the pass-through flags.
Should we run this part by them too, or?

[bradnelson, 2014-02-28 00:14:56]

lgtm

[jvoung (off chromium), 2014-02-28 17:03:09]

The CQ bit was checked by jvoung@chromium.org

[commit-bot: I haz the power, 2014-02-28 17:03:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@chromium.org/181153002/70001

[commit-bot: I haz the power, 2014-02-28 17:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-28 17:07:22]

Try jobs failed on following builders: linux_chromium_rel

[jvoung (off chromium), 2014-02-28 17:16:23]

The CQ bit was checked by jvoung@chromium.org

[commit-bot: I haz the power, 2014-02-28 17:16:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@chromium.org/181153002/70001

[commit-bot: I haz the power, 2014-02-28 20:37:17]

Change committed as 254212

[jvoung (off chromium), 2014-03-04 19:43:53]

Uploaded a second try at this CL (previous one was reverted because we couldn't
allocate the sandbox address space on 32-bit XP bots).  I changed the test to
only attempt one translation-and-load at a time instead of possibly doing two
simulatenously.

[teravest, 2014-03-04 19:52:36]

lgtm

[bradnelson, 2014-03-04 19:59:05]

lgtm

[jvoung (off chromium), 2014-03-04 21:32:12]

The CQ bit was checked by jvoung@chromium.org

[commit-bot: I haz the power, 2014-03-04 21:32:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@chromium.org/181153002/110001

[commit-bot: I haz the power, 2014-03-04 22:02:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-04 22:02:59]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, base_unittests, browser_tests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chrome_elf_unittests, chromedriver_unittests, components_unittests,
compositor_unittests, content_browsertests, content_unittests, crypto_unittests,
events_unittests, gfx_unittests, google_apis_unittests, gpu_unittests,
installer_util_unittests, interactive_ui_tests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, net_unittests,
ppapi_unittests, printing_unittests, remoting_unittests, sql_unittests,
sync_integration_tests, sync_unit_tests, telemetry_perf_unittests,
telemetry_unittests, unit_tests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[jvoung (off chromium), 2014-03-06 21:06:21]

The CQ bit was checked by jvoung@chromium.org

[commit-bot: I haz the power, 2014-03-06 21:14:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@chromium.org/181153002/110001

[commit-bot: I haz the power, 2014-03-06 22:01:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jvoung@chromium.org/181153002/110001

[jvoung (off chromium), 2014-03-07 02:32:31]

Committed patchset #7 manually as r255499 (presubmit successful).