ppapi/native_client/src/trusted/plugin/pnacl_options.cc - Issue 181153002: Have PNaCl use debug pexe URL instead of stripped pexe w/ kEnableNaClDebug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/trusted/plugin/pnacl_options.cc

Issue 181153002: Have PNaCl use debug pexe URL instead of stripped pexe w/ kEnableNaClDebug (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: split the test Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/trusted/plugin/pnacl_options.h ('k') | ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/trusted/plugin/pnacl_options.cc

diff --git a/ppapi/native_client/src/trusted/plugin/pnacl_options.cc b/ppapi/native_client/src/trusted/plugin/pnacl_options.cc

index 6985883175ee04c1c34fabe418f56b056d46a2f0..b02e1f04565f54cbbdecdf7d27d12f2f1418337f 100644

--- a/ppapi/native_client/src/trusted/plugin/pnacl_options.cc

+++ b/ppapi/native_client/src/trusted/plugin/pnacl_options.cc

@@ -11,7 +11,11 @@

namespace plugin {

-PnaclOptions::PnaclOptions() : translate_(false), opt_level_(2) { }

+PnaclOptions::PnaclOptions()

+ : translate_(false),

+ is_debug_(false),

+ opt_level_(2) {

PnaclOptions::~PnaclOptions() {

}

@@ -31,6 +35,10 @@ std::vector<char> PnaclOptions::GetOptCommandline() const {

nacl::stringstream ss;

ss << "-O" << opt_level_;

+ // Debug info is only available in LLVM format pexes,

+ // not in PNaCl format pexes.

+ if (is_debug_)

+ ss << "\x00-bitcode-format=llvm";

str = ss.str();

std::copy(str.begin(), str.end(), std::back_inserter(result));