IAccessible::get_accChild should only return a descendant.

IAccessible::get_accChild should only return a descendant.

BUG=595959
Committed: https://crrev.com/cc0f7046968cec63bf2fbebc60ed10a5c725b3d3
Cr-Commit-Position: refs/heads/master@{#382050}

[dmazzoni, 2016-03-18 18:07:59]

dmazzoni@chromium.org changed reviewers:
+ nektar@chromium.org

[nektarios, 2016-03-18 19:13:23]

BrowserAccessibilityWin* child =
ToBrowserAccessibilityWin(BrowserAccessibility::GetFromUniqueID(-child_id));
  if (child && child->IsDescendantOf(this))
   return child;

I think that IsDescendantOf returns true if the object == this. You might want
to change it to:
  if (!child || !child->IsDescendantOf(this))
    return nullptr;

Does the same behavior happen in AXPlatformNodeWin?

[nektarios, 2016-03-18 19:13:34]

lgtm

[dmazzoni, 2016-03-18 19:23:24]

On 2016/03/18 19:13:23, nektarios wrote:
> BrowserAccessibilityWin* child =
> ToBrowserAccessibilityWin(BrowserAccessibility::GetFromUniqueID(-child_id));
>   if (child && child->IsDescendantOf(this))
>    return child;
> 
> I think that IsDescendantOf returns true if the object == this. You might want
> to change it to:
>   if (!child || !child->IsDescendantOf(this))
>     return nullptr;
> 
> Does the same behavior happen in AXPlatformNodeWin?

They're both defined that way. Considering that get_accChild is allowed to
return the same object when you pass 0, it seems like maybe it should return
itself if you pass its unique id too.

[dmazzoni, 2016-03-18 19:23:28]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2016-03-18 19:24:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811403002/1

[commit-bot: I haz the power, 2016-03-18 19:30:14]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-18 19:32:26]

Description was changed from

==========
IAccessible::get_accChild should only return a descendant.

BUG=595959
==========

to

==========
IAccessible::get_accChild should only return a descendant.

BUG=595959

Committed: https://crrev.com/cc0f7046968cec63bf2fbebc60ed10a5c725b3d3
Cr-Commit-Position: refs/heads/master@{#382050}
==========

[commit-bot: I haz the power, 2016-03-18 19:32:27]

Patchset 1 (id:??) landed as
https://crrev.com/cc0f7046968cec63bf2fbebc60ed10a5c725b3d3
Cr-Commit-Position: refs/heads/master@{#382050}