ui/accessibility/platform/ax_platform_node_base.cc - Issue 1811403002: IAccessible::get_accChild should only return a descendant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/accessibility/platform/ax_platform_node_base.cc

Issue 1811403002: IAccessible::get_accChild should only return a descendant. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_win_unittest.cc ('k') | ui/accessibility/platform/ax_platform_node_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/accessibility/platform/ax_platform_node_base.cc

diff --git a/ui/accessibility/platform/ax_platform_node_base.cc b/ui/accessibility/platform/ax_platform_node_base.cc

index a9d4c1f0bc2630a15cd1e532be84f79e689ddc7a..4937e4d317876f64573f982ae687bddeef132d16 100644

--- a/ui/accessibility/platform/ax_platform_node_base.cc

+++ b/ui/accessibility/platform/ax_platform_node_base.cc

@@ -93,7 +93,10 @@ bool AXPlatformNodeBase::IsDescendant(AXPlatformNodeBase* node) {

return false;

if (node == this)

return true;

- AXPlatformNodeBase* parent = FromNativeViewAccessible(node->GetParent());

+ gfx::NativeViewAccessible native_parent = node->GetParent();

+ if (!native_parent)

+ return false;

+ AXPlatformNodeBase* parent = FromNativeViewAccessible(native_parent);

return IsDescendant(parent);

}