Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 181133002: Allow arbitrary values for [SetWrapperReferenceFrom] (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, adamk
Visibility:
Public.

Description

Allow arbitrary values for [SetWrapperReferenceFrom] Per Adam Klein's comment at: https://codereview.chromium.org/161083002/#msg4 this CL removes the explicit list of allowed values from [SetWrapperReferenceFrom], since it's just an arbitrary function name. Per haraken's comment at: https://codereview.chromium.org/161083002/#msg5 this is ok, so TBR'ing. TBR=haraken BUG=345503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/bindings/IDLExtendedAttributes.txt View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-26 07:23:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/181133002/1
6 years, 10 months ago (2014-02-26 07:23:28 UTC) #2
Nils Barth (inactive)
+adamk
6 years, 10 months ago (2014-02-26 07:24:27 UTC) #3
haraken
LGTM
6 years, 10 months ago (2014-02-26 07:31:54 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-26 09:18:19 UTC) #5
Message was sent while issue was closed.
Change committed as 167876

Powered by Google App Engine
This is Rietveld 408576698