Remove NetworkDelegate from HttpNetworkSession.

Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=zea@chromium.org, mkwst@chromium.org
BUG=none

Committed: https://crrev.com/39c0d5159558e7dc72341b47f5e07e678c82541f
Cr-Commit-Position: refs/heads/master@{#382031}

[mmenke, 2016-03-18 16:18:49]

Description was changed from

==========
Remove NetworkDelegate from HttpNetworkSession.

Nothing is currently using it, and currently, HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove this while we can.

BUG=none
==========

to

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

BUG=none
==========

[mmenke, 2016-03-18 17:12:00]

Patchset #2 (id:20001) has been deleted

[mmenke, 2016-03-18 17:12:45]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2016-03-18 17:12:46]

Noticed this field during another review.

[eroman, 2016-03-18 17:21:25]

lgtm!

https://codereview.chromium.org/1811283004/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/1811283004/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:878: // remove DRP
data this from net-internals entirely?
phrasing?

[mmenke, 2016-03-18 17:24:00]

Thanks!

https://codereview.chromium.org/1811283004/diff/40001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/net_internals/net_internals_ui.cc (right):

https://codereview.chromium.org/1811283004/diff/40001/chrome/browser/ui/webui...
chrome/browser/ui/webui/net_internals/net_internals_ui.cc:878: // remove DRP
data this from net-internals entirely?
On 2016/03/18 17:21:25, eroman wrote:
> phrasing?

Done.

[mmenke, 2016-03-18 17:31:57]

mmenke@chromium.org changed reviewers:
+ mkwst@chromium.org, skyostil@chromium.org, stuartmorgan@chromium.org,
zea@chromium.org

[mmenke, 2016-03-18 17:31:58]

This is a trivial CL that removes code that sets a parameter that does nothing
from HttpSession::Params, so planning to TBR everyone on this one.

[+mkwst]:  content/shell
[+zea]:  jingle, google_apis/gcm
[+stuartmorgan]:  iOS
[+skyostil]:  Headless

[mmenke, 2016-03-18 17:32:33]

Description was changed from

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

BUG=none
==========

to

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=stuartmorgan@chromium.org, zea@chromium.org, mkwst@chromium.org,
skyostil@chromium.org
BUG=none
==========

[mmenke, 2016-03-18 17:37:15]

Description was changed from

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=stuartmorgan@chromium.org, zea@chromium.org, mkwst@chromium.org,
skyostil@chromium.org
BUG=none
==========

to

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=stuartmorgan@chromium.org, zea@chromium.org, mkwst@chromium.org,
skyostil@chromium.org
BUG=none
==========

[stuartmorgan, 2016-03-18 17:42:16]

ios RS LGTM

[mmenke, 2016-03-18 17:43:40]

Description was changed from

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=stuartmorgan@chromium.org, zea@chromium.org, mkwst@chromium.org,
skyostil@chromium.org
BUG=none
==========

to

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=zea@chromium.org, mkwst@chromium.org, skyostil@chromium.org
BUG=none
==========

[mmenke, 2016-03-18 17:44:01]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-03-18 17:44:01]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/1811283004/#ps60001
(title: "Response to comments")

[commit-bot: I haz the power, 2016-03-18 17:44:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1811283004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1811283004/60001

[Sami, 2016-03-18 18:06:37]

headless lgtm.

[mmenke, 2016-03-18 18:10:06]

Description was changed from

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=zea@chromium.org, mkwst@chromium.org, skyostil@chromium.org
BUG=none
==========

to

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=zea@chromium.org, mkwst@chromium.org
BUG=none
==========

[commit-bot: I haz the power, 2016-03-18 18:46:31]

Description was changed from

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=zea@chromium.org, mkwst@chromium.org
BUG=none
==========

to

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=zea@chromium.org, mkwst@chromium.org
BUG=none
==========

[commit-bot: I haz the power, 2016-03-18 18:46:33]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-03-18 18:47:46]

Description was changed from

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=zea@chromium.org, mkwst@chromium.org
BUG=none
==========

to

==========
Remove NetworkDelegate pointer from HttpNetworkSession.

Nothing is currently using it, and currently HttpNetworkSessions
can be shared by URLRequestContexts with different NetworkDelegates,
so best to remove the field.

TBR=zea@chromium.org, mkwst@chromium.org
BUG=none

Committed: https://crrev.com/39c0d5159558e7dc72341b47f5e07e678c82541f
Cr-Commit-Position: refs/heads/master@{#382031}
==========

[commit-bot: I haz the power, 2016-03-18 18:47:47]

Patchset 3 (id:??) landed as
https://crrev.com/39c0d5159558e7dc72341b47f5e07e678c82541f
Cr-Commit-Position: refs/heads/master@{#382031}