google_apis/gcm/tools/mcs_probe.cc - Issue 1811283004: Remove NetworkDelegate from HttpNetworkSession.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/tools/mcs_probe.cc

Issue 1811283004: Remove NetworkDelegate from HttpNetworkSession. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Response to comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/tools/mcs_probe.cc

diff --git a/google_apis/gcm/tools/mcs_probe.cc b/google_apis/gcm/tools/mcs_probe.cc

index aafd4dbd71086dccfc6cc44ac4dfedcdc72d97db..1a3256d1bdb1703e570f426c3556e2e548a65fc2 100644

--- a/google_apis/gcm/tools/mcs_probe.cc

+++ b/google_apis/gcm/tools/mcs_probe.cc

@@ -418,7 +418,6 @@ void MCSProbe::BuildNetworkSession() {

session_params.http_auth_handler_factory = http_auth_handler_factory_.get();

session_params.http_server_properties =

http_server_properties_->GetWeakPtr();

- session_params.network_delegate = NULL; // TODO(zea): implement?

session_params.host_mapping_rules = host_mapping_rules_.get();

session_params.ignore_certificate_errors = true;

session_params.testing_fixed_http_port = 0;