Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 1811213003: [turbofan] Validation for deferred->hot transition edges (Closed)

Created:
4 years, 9 months ago by Mircea Trofin
Modified:
4 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@validations
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Validation for deferred->hot transition edges Validate that the transition from deferred to hot happens through a deferred block with one successor. This is needed for frame elision: if we need to deconstruct the frame on the deferred path, this extra block offers that location. A precondition for this validation is that the sequence is in split edge form. BUG= Committed: https://crrev.com/66c6cadc4d1d4aab55c7a76acde791195ada100f Cr-Commit-Position: refs/heads/master@{#35015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/compiler/instruction.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (9 generated)
Mircea Trofin
4 years, 9 months ago (2016-03-18 16:57:52 UTC) #3
danno
lgtm
4 years, 9 months ago (2016-03-18 17:02:05 UTC) #4
danno
lgtm. Adding a compiler OWNER for a real lgtm.
4 years, 9 months ago (2016-03-22 17:46:33 UTC) #6
Benedikt Meurer
lgtm
4 years, 9 months ago (2016-03-23 06:06:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811213003/1
4 years, 9 months ago (2016-03-23 07:35:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/12066) v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, ...
4 years, 9 months ago (2016-03-23 07:37:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811213003/1
4 years, 9 months ago (2016-03-23 07:49:56 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 08:11:21 UTC) #16
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 08:11:45 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66c6cadc4d1d4aab55c7a76acde791195ada100f
Cr-Commit-Position: refs/heads/master@{#35015}

Powered by Google App Engine
This is Rietveld 408576698