Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1810293003: [turbofan] Moved split edge form validation lower (Closed)

Created:
4 years, 9 months ago by Mircea Trofin
Modified:
4 years, 9 months ago
Reviewers:
danno
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Moved split edge form validation lower. There are multiple ways we may construct an instruction sequence. Moved the split edge form validation where they must all eventually chokepoint to - the register allocation pipeline, which is also the main and first consumer of this property. BUG= Committed: https://crrev.com/da81f841f4bae14fe522349f6679e72d24c5c7d4 Cr-Commit-Position: refs/heads/master@{#34903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M src/compiler/instruction.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Mircea Trofin
4 years, 9 months ago (2016-03-18 16:42:21 UTC) #3
danno
lgtm
4 years, 9 months ago (2016-03-18 16:45:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810293003/1
4 years, 9 months ago (2016-03-18 17:18:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-18 17:20:38 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 17:22:38 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da81f841f4bae14fe522349f6679e72d24c5c7d4
Cr-Commit-Position: refs/heads/master@{#34903}

Powered by Google App Engine
This is Rietveld 408576698