Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 1811203003: [GN] Fix "gn gen --ide=vs" to ignore bundle_data targets. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, tfarina, Tomasz Moniuszko, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@fixes
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[GN] Fix "gn gen --ide=vs" to ignore bundle_data targets. In order to keep the BUILD.gn more readable by avoiding conditionals, Chromium defines bundle_data on every platforms (as in the absence of create_bundle they are just no-op stamp targets). Fix "gn gen --ide=vs" to ignore bundle_data targets but not the create_bundle targets (as there should be no such targets on Windows). BUG=595915 Committed: https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2 Cr-Commit-Position: refs/heads/master@{#382197}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M tools/gn/visual_studio_writer.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
sdefresne
Please take a look (and please send to CQ if you have no comments). jam/tmoniusko: ...
4 years, 9 months ago (2016-03-18 15:37:55 UTC) #2
brettw
lgtm
4 years, 9 months ago (2016-03-18 21:19:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1811203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1811203003/1
4 years, 9 months ago (2016-03-19 13:29:31 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-19 13:34:36 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-19 13:36:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a90c62f80a74f7abc647234f70ac596e86bf3dd2
Cr-Commit-Position: refs/heads/master@{#382197}

Powered by Google App Engine
This is Rietveld 408576698