Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: tools/gn/visual_studio_writer.cc

Issue 1811203003: [GN] Fix "gn gen --ide=vs" to ignore bundle_data targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fixes
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/visual_studio_writer.cc
diff --git a/tools/gn/visual_studio_writer.cc b/tools/gn/visual_studio_writer.cc
index 54a7bf2e5fee2ad133abf4568fe65743af3ddd1e..801ea7761d4e646d21baa36e3171f2410c7f85cc 100644
--- a/tools/gn/visual_studio_writer.cc
+++ b/tools/gn/visual_studio_writer.cc
@@ -259,11 +259,12 @@ bool VisualStudioWriter::RunAndWriteFiles(const BuildSettings* build_settings,
writer.folders_.reserve(targets.size());
for (const Target* target : targets) {
- // Skip actions and groups.
+ // Skip actions, groups and bundle targets.
if (target->output_type() == Target::GROUP ||
target->output_type() == Target::COPY_FILES ||
target->output_type() == Target::ACTION ||
- target->output_type() == Target::ACTION_FOREACH) {
+ target->output_type() == Target::ACTION_FOREACH ||
+ target->output_type() == Target::BUNDLE_DATA) {
continue;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698