Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1810843002: DevTools: split protocol Dispatcher into Backend interface and the dispatcher itself. (Closed)

Created:
4 years, 9 months ago by pfeldman
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, shans, apavlov+blink_chromium.org, dmazzoni+watch_chromium.org, kinuko+watch, timvolodine, caseq+blink_chromium.org, aboxhall, mvanouwerkerk+watch_chromium.org, aboxhall+watch_chromium.org, je_julie, devtools-reviews_chromium.org, blink-reviews, Eric Willigers, rjwright, cmumford, lushnikov+blink_chromium.org, dmazzoni, yuzo+watch_chromium.org, darktears, jsbell+idb_chromium.org, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, pfeldman+blink_chromium.org, nektarios, dtseng+watch_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: split protocol Dispatcher into Backend interface and the dispatcher itself. BUG=580337 Committed: https://crrev.com/712e7b24ad99261376251d3d789c69339f9e5904 Cr-Commit-Position: refs/heads/master@{#381820}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -226 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.h View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorAnimationAgent.cpp View 13 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorApplicationCacheAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorMemoryAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorPageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorRuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorTracingAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/InspectorAccessibilityAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Backend_cpp.template View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/inspector_protocol/Backend_h.template View 4 chunks +9 lines, -44 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py View 2 chunks +12 lines, -8 lines 1 comment Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template View 6 chunks +57 lines, -48 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template View 2 chunks +2 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/platform/inspector_protocol/protocol.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8HeapProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8ProfilerAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.h View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
pfeldman
4 years, 9 months ago (2016-03-17 02:01:58 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1810843002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py (right): https://codereview.chromium.org/1810843002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py#newcode43 third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:43: generate_dispatcher = arg_options.generate_dispatcher You don't use this.
4 years, 9 months ago (2016-03-17 20:39:23 UTC) #3
pfeldman
On 2016/03/17 20:39:23, dgozman wrote: > lgtm > > https://codereview.chromium.org/1810843002/diff/1/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py > File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py > (right): ...
4 years, 9 months ago (2016-03-17 21:10:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810843002/1
4 years, 9 months ago (2016-03-17 21:11:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-17 22:51:25 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-17 22:53:47 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/712e7b24ad99261376251d3d789c69339f9e5904
Cr-Commit-Position: refs/heads/master@{#381820}

Powered by Google App Engine
This is Rietveld 408576698