DevTools: split protocol Dispatcher into Backend interface and the dispatcher itself.

third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os.path
 import sys
 import string
 import optparse
 import re
 try:
@@ skipping 15 matching lines @@
     module_path, os.pardir, os.pardir, os.pardir, os.pardir))
 
 # jinja2 is in chromium's third_party directory.
 # Insert at 1 so at front to override system libraries, and
 # after path[0] == invoking script dir
 sys.path.insert(1, third_party_dir)
 import jinja2
 
 cmdline_parser = optparse.OptionParser()
 cmdline_parser.add_option("--output_dir")
-cmdline_parser.add_option("--template_dir")
+cmdline_parser.add_option("--generate_dispatcher")
 
 try:
     arg_options, arg_values = cmdline_parser.parse_args()
-    if (len(arg_values) != 1):
-        raise Exception("Exactly one plain argument expected (found %s)" % len(arg_values))
-    input_json_filename = arg_values[0]
+    if (len(arg_values) == 0):
+        raise Exception("At least one plain argument expected (found %s)" % len(arg_values))
     output_dirname = arg_options.output_dir
+    generate_dispatcher = arg_options.generate_dispatcher

[dgozman, 2016/03/17 20:39:23]

You don't use this.

     if not output_dirname:
         raise Exception("Output directory must be specified")
 except Exception:
     # Work with python 2 and 3 http://docs.python.org/py3k/howto/pyporting.html
     exc = sys.exc_info()[1]
     sys.stderr.write("Failed to parse command-line arguments: %s\n\n" % exc)
-    sys.stderr.write("Usage: <script> --output_dir <output_dir> protocol.json\n")
+    sys.stderr.write("Usage: <script> --output_dir <output_dir> blink_protocol.json v8_protocol.json ...\n")
     exit(1)
 
-input_file = open(input_json_filename, "r")
-json_string = input_file.read()
-json_api = json.loads(json_string)
+json_api = {"domains": []}
 
+for filename in arg_values:
+    input_file = open(filename, "r")
+    json_string = input_file.read()
+    parsed_json = json.loads(json_string)
+    json_api["domains"] += parsed_json["domains"]
 
 def to_title_case(name):
     return name[:1].upper() + name[1:]
 
 
 def dash_to_camelcase(word):
     return ''.join(to_title_case(x) or '-' for x in word.split('-'))
 
 
 def initialize_jinja_env(cache_dir):
@@ skipping 194 matching lines @@
     cpp_template = jinja_env.get_template("/%s_cpp.template" % class_name)
     h_file = output_file(output_dirname + "/" + class_name + ".h")
     cpp_file = output_file(output_dirname + "/" + class_name + ".cpp")
     h_file.write(h_template.render(template_context))
     cpp_file.write(cpp_template.render(template_context))
     h_file.close()
     cpp_file.close()
 
 
 jinja_env = initialize_jinja_env(output_dirname)
+generate("Backend")
 generate("Dispatcher")
 generate("Frontend")
 generate("TypeBuilder")