Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1806203002: Kill login after logging in. (Closed)

Created:
4 years, 9 months ago by Ben Goodger (Google)
Modified:
4 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@56cascade
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rather than keeping it around forever, we should kill it. Now that the user shell is acting as the login broker for apps run for that user, it's not necessary to keep login too. This simplifies the login app a bit. BUG= Committed: https://crrev.com/5953178290205c37dbe478fcba0048d2141dcaf3 Cr-Commit-Position: refs/heads/master@{#381856}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -293 lines) Patch
M mash/init/init.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M mash/init/init.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M mash/init/manifest.json View 1 chunk +1 line, -1 line 0 comments Download
M mash/login/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M mash/login/login.h View 1 1 chunk +3 lines, -38 lines 0 comments Download
M mash/login/login.cc View 1 2 3 4 5 1 chunk +170 lines, -39 lines 0 comments Download
M mash/login/main.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mash/login/ui.h View 1 1 chunk +0 lines, -69 lines 0 comments Download
M mash/login/ui.cc View 1 1 chunk +0 lines, -136 lines 0 comments Download
M mojo/shell/runner/host/child_process_host.h View 1 5 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/runner/host/child_process_host.cc View 1 2 3 4 5 2 chunks +6 lines, -1 line 0 comments Download
M mojo/shell/runner/host/child_process_host_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M mojo/shell/runner/host/out_of_process_native_runner.cc View 1 5 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/screen_mus.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
sky
LGTM
4 years, 9 months ago (2016-03-17 23:21:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1806203002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1806203002/120001
4 years, 9 months ago (2016-03-17 23:29:40 UTC) #6
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 9 months ago (2016-03-18 00:54:58 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 00:56:22 UTC) #10
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/5953178290205c37dbe478fcba0048d2141dcaf3
Cr-Commit-Position: refs/heads/master@{#381856}

Powered by Google App Engine
This is Rietveld 408576698