Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1810683002: [Findit] Fix KeyError when no failed targets are extracted. (Closed)

Created:
4 years, 9 months ago by stgao
Modified:
4 years, 9 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Fix KeyError when no failed targets are extracted. BUG=595394 Committed: https://chromium.googlesource.com/infra/infra/+/c4f0b1873de43ee326d24e8a6dbcdb63b3a0a8ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M appengine/findit/waterfall/test/try_job_util_test.py View 1 chunk +4 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/try_job_util.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
stgao
ptal. Just a few line change.
4 years, 9 months ago (2016-03-16 18:36:57 UTC) #4
chanli
On 2016/03/16 18:36:57, stgao wrote: > ptal. Just a few line change. lgtm
4 years, 9 months ago (2016-03-16 18:39:37 UTC) #6
lijeffrey
lgtm
4 years, 9 months ago (2016-03-16 19:10:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810683002/1
4 years, 9 months ago (2016-03-16 19:30:58 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 19:34:15 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/c4f0b1873de43ee326d24e8a6dbcd...

Powered by Google App Engine
This is Rietveld 408576698