appengine/findit/waterfall/try_job_util.py - Issue 1810683002: [Findit] Fix KeyError when no failed targets are extracted.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/try_job_util.py

Issue 1810683002: [Findit] Fix KeyError when no failed targets are extracted. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/waterfall/try_job_util.py

diff --git a/appengine/findit/waterfall/try_job_util.py b/appengine/findit/waterfall/try_job_util.py

index 891edbd15b48cad22a42b2381f80df4aada6d89b..87f0eda82aec4aa2befa529f7fd1446af7c4c618 100644

--- a/appengine/findit/waterfall/try_job_util.py

+++ b/appengine/findit/waterfall/try_job_util.py

@@ -125,7 +125,7 @@ def _GetFailedTargetsFromSignals(signals, master_name, builder_name):

strict_regex = waterfall_config.EnableStrictRegexForCompileLinkFailures(

master_name, builder_name)

- for source_target in signals['compile']['failed_targets']:

+ for source_target in signals['compile'].get('failed_targets', []):

# For link failures, we pass the executable targets directly to try-job, and

# there is no 'source' for link failures.

# For compile failures, only pass the object files as the compile targets

« no previous file with comments | « appengine/findit/waterfall/test/try_job_util_test.py ('k') | no next file » | no next file with comments »