Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: scripts/slave/recipes/infra/rebaseline_o_matic.py

Issue 1810653002: Improve docs on rebaseline git config user name/email override. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipes/infra/rebaseline_o_matic.py
diff --git a/scripts/slave/recipes/infra/rebaseline_o_matic.py b/scripts/slave/recipes/infra/rebaseline_o_matic.py
index c9683fa1d73dbe19eaaf68a5a8102e260c552e40..bbf11b03e68955092b9c15b04379fdd1a09384cd 100644
--- a/scripts/slave/recipes/infra/rebaseline_o_matic.py
+++ b/scripts/slave/recipes/infra/rebaseline_o_matic.py
@@ -31,6 +31,17 @@ def RunSteps(api):
cwd = api.path['checkout'].join('third_party', 'WebKit')
# Changes should be committed and landed as the rebaseline bot role account.
+ # The base chromium repo setup configures chrome-bot@ as the author/committer.
+ # We could attempt use of command-line arguments to git commands to specify
+ # the rebaseline bot name/email, but in fact this is insufficient to override
+ # due to precedence. Environment variables would likely work per the man page
+ # for git-commit-tree, but would require changes through both the auto-
+ # rebaseline script and 'git cl land', with this bot as the only intended
+ # customer.
+ #
+ # Given all tradeoffs, setting the chromium repo's user name/email to the
+ # intended rebaseline bot parameters in a persistent manner is deemed a
+ # reasonable alternate approach.
api.git('config', 'user.name', 'Rebaseline Bot')
api.git('config', 'user.email', 'blink-rebaseline-bot@chromium.org')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698