Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Side by Side Diff: scripts/slave/recipes/infra/rebaseline_o_matic.py

Issue 1810653002: Improve docs on rebaseline git config user name/email override. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Generates new baselines for Blink layout tests that need rebaselining. 5 """Generates new baselines for Blink layout tests that need rebaselining.
6 6
7 Intended to be called periodically. Syncs to the Blink repo and runs 7 Intended to be called periodically. Syncs to the Blink repo and runs
8 'webkit-patch auto-rebaseline', which processes entries in 8 'webkit-patch auto-rebaseline', which processes entries in
9 LayoutTests/TestExpectations that are marked with 'NeedsRebaseline'. 9 LayoutTests/TestExpectations that are marked with 'NeedsRebaseline'.
10 10
(...skipping 13 matching lines...) Expand all
24 24
25 def RunSteps(api): 25 def RunSteps(api):
26 RIETVELD_REFRESH_TOKEN = '/creds/refresh_tokens/blink_rebaseline_bot_rietveld' 26 RIETVELD_REFRESH_TOKEN = '/creds/refresh_tokens/blink_rebaseline_bot_rietveld'
27 27
28 api.gclient.set_config('chromium') 28 api.gclient.set_config('chromium')
29 api.bot_update.ensure_checkout(force=True) 29 api.bot_update.ensure_checkout(force=True)
30 30
31 cwd = api.path['checkout'].join('third_party', 'WebKit') 31 cwd = api.path['checkout'].join('third_party', 'WebKit')
32 32
33 # Changes should be committed and landed as the rebaseline bot role account. 33 # Changes should be committed and landed as the rebaseline bot role account.
34 # The base chromium repo setup configures chrome-bot@ as the author/committer.
35 # We could attempt use of command-line arguments to git commands to specify
36 # the rebaseline bot name/email, but in fact this is insufficient to override
37 # due to precedence. Environment variables would likely work per the man page
38 # for git-commit-tree, but would require changes through both the auto-
39 # rebaseline script and 'git cl land', with this bot as the only intended
40 # customer.
41 #
42 # Given all tradeoffs, setting the chromium repo's user name/email to the
43 # intended rebaseline bot parameters in a persistent manner is deemed a
44 # reasonable alternate approach.
34 api.git('config', 'user.name', 'Rebaseline Bot') 45 api.git('config', 'user.name', 'Rebaseline Bot')
35 api.git('config', 'user.email', 'blink-rebaseline-bot@chromium.org') 46 api.git('config', 'user.email', 'blink-rebaseline-bot@chromium.org')
36 47
37 api.python('webkit-patch auto-rebaseline', 48 api.python('webkit-patch auto-rebaseline',
38 cwd.join('Tools', 'Scripts', 'webkit-patch'), 49 cwd.join('Tools', 'Scripts', 'webkit-patch'),
39 ['auto-rebaseline', '--verbose', 50 ['auto-rebaseline', '--verbose',
40 '--auth-refresh-token-json', RIETVELD_REFRESH_TOKEN], 51 '--auth-refresh-token-json', RIETVELD_REFRESH_TOKEN],
41 cwd=cwd) 52 cwd=cwd)
42 53
43 54
44 def GenTests(api): 55 def GenTests(api):
45 yield (api.test('rebaseline_o_matic') + 56 yield (api.test('rebaseline_o_matic') +
46 api.properties(mastername='chromium.infra.cron', 57 api.properties(mastername='chromium.infra.cron',
47 buildername='rebaseline-o-matic', 58 buildername='rebaseline-o-matic',
48 slavename='fake-slave')) 59 slavename='fake-slave'))
49 60
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698