Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 1810633002: [WebView] Remove DEPRECATED_java_in_dir from android_webview_java. (Closed)

Created:
4 years, 9 months ago by mikecase (-- gone --)
Modified:
4 years, 9 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Remove DEPRECATED_java_in_dir from android_webview_java. BUG= Committed: https://crrev.com/2e4993c912afe61d1edb02ce1edf770c65481ed2 Cr-Commit-Position: refs/heads/master@{#381521}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
M android_webview/BUILD.gn View 1 chunk +64 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
mikecase (-- gone --)
Might as well remove DEPRECATED_java_in_dir everywhere so people aren't confused when they have to add ...
4 years, 9 months ago (2016-03-16 17:18:35 UTC) #2
boliu
lgtm
4 years, 9 months ago (2016-03-16 17:20:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810633002/1
4 years, 9 months ago (2016-03-16 18:43:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:41:33 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:44:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e4993c912afe61d1edb02ce1edf770c65481ed2
Cr-Commit-Position: refs/heads/master@{#381521}

Powered by Google App Engine
This is Rietveld 408576698