Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1801033004: [WebView] Remove DEPRECATED_java_in_dir from android_webview test. (Closed)

Created:
4 years, 9 months ago by mikecase (-- gone --)
Modified:
4 years, 9 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebView] Remove DEPRECATED_java_in_dir from android_webview test. Removing DEPRECATED_java_in_dir from the AndroidWebview apk test targets. Note that this will mean if you want to add a new test file or a new file to add to the AndroidWebView shell apk you will need to add the file explicitly to the java_files list. BUG= Committed: https://crrev.com/000a29da7f20bcb0c343108ca5590af87e1a0ad1 Cr-Commit-Position: refs/heads/master@{#381526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -3 lines) Patch
M android_webview/test/BUILD.gn View 3 chunks +101 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mikecase (-- gone --)
4 years, 9 months ago (2016-03-15 21:34:05 UTC) #2
boliu
rs lgtm Two manual things: * Verify that we didn't accidentally drop any tests. Maybe ...
4 years, 9 months ago (2016-03-15 21:36:11 UTC) #3
sgurun-gerrit only
On 2016/03/15 21:36:11, boliu wrote: > rs lgtm > > Two manual things: > * ...
4 years, 9 months ago (2016-03-16 15:34:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801033004/1
4 years, 9 months ago (2016-03-16 18:43:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-16 20:45:47 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-16 20:48:18 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/000a29da7f20bcb0c343108ca5590af87e1a0ad1
Cr-Commit-Position: refs/heads/master@{#381526}

Powered by Google App Engine
This is Rietveld 408576698