Issue 181063033: Ignore slots buffer overflow when recording entries of the allocation sites scratchpad.

Issue 181063033: Ignore slots buffer overflow when recording entries of the allocation sites scratchpad. (Closed)

Created:
6 years, 9 months ago by Hannes Payer (out of office)

Modified:
6 years, 9 months ago

Reviewers:
ulan, Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ignore slots buffer overflow when recording entries of the allocation sites scratchpad. BUG= R=mstarzinger@chromium.org, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19677

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -11 lines)			Patch
M	src/heap.h	View		2 chunks	+9 lines, -2 lines	0 comments	Download
M	src/heap.cc	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
M	src/heap-inl.h	View		3 chunks	+4 lines, -3 lines	0 comments	Download
M	src/mark-compact.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	src/mark-compact.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact-inl.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. https://codereview.chromium.org/181063033/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/181063033/diff/1/src/heap.cc#newcode3669 src/heap.cc:3669: mark_compact_collector()->RecordSlot( Can we get a short comment explaining ...

6 years, 9 months ago (2014-03-05 13:58:11 UTC) #2

Hannes Payer (out of office)

https://codereview.chromium.org/181063033/diff/1/src/heap.cc File src/heap.cc (right): https://codereview.chromium.org/181063033/diff/1/src/heap.cc#newcode3669 src/heap.cc:3669: mark_compact_collector()->RecordSlot( On 2014/03/05 13:58:11, Michael Starzinger wrote: > Can ...

6 years, 9 months ago (2014-03-05 14:02:06 UTC) #3

Hannes Payer (out of office)

6 years, 9 months ago (2014-03-05 14:04:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r19677 (tree was closed).

Expand Messages | Collapse Messages