Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: src/mark-compact-inl.h

Issue 181063033: Ignore slots buffer overflow when recording entries of the allocation sites scratchpad. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mark-compact.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 74
75 bool MarkCompactCollector::IsMarked(Object* obj) { 75 bool MarkCompactCollector::IsMarked(Object* obj) {
76 ASSERT(obj->IsHeapObject()); 76 ASSERT(obj->IsHeapObject());
77 HeapObject* heap_object = HeapObject::cast(obj); 77 HeapObject* heap_object = HeapObject::cast(obj);
78 return Marking::MarkBitFrom(heap_object).Get(); 78 return Marking::MarkBitFrom(heap_object).Get();
79 } 79 }
80 80
81 81
82 void MarkCompactCollector::RecordSlot(Object** anchor_slot, 82 void MarkCompactCollector::RecordSlot(Object** anchor_slot,
83 Object** slot, 83 Object** slot,
84 Object* object) { 84 Object* object,
85 SlotsBuffer::AdditionMode mode) {
85 Page* object_page = Page::FromAddress(reinterpret_cast<Address>(object)); 86 Page* object_page = Page::FromAddress(reinterpret_cast<Address>(object));
86 if (object_page->IsEvacuationCandidate() && 87 if (object_page->IsEvacuationCandidate() &&
87 !ShouldSkipEvacuationSlotRecording(anchor_slot)) { 88 !ShouldSkipEvacuationSlotRecording(anchor_slot)) {
88 if (!SlotsBuffer::AddTo(&slots_buffer_allocator_, 89 if (!SlotsBuffer::AddTo(&slots_buffer_allocator_,
89 object_page->slots_buffer_address(), 90 object_page->slots_buffer_address(),
90 slot, 91 slot,
91 SlotsBuffer::FAIL_ON_OVERFLOW)) { 92 mode)) {
92 EvictEvacuationCandidate(object_page); 93 EvictEvacuationCandidate(object_page);
93 } 94 }
94 } 95 }
95 } 96 }
96 97
97 98
98 } } // namespace v8::internal 99 } } // namespace v8::internal
99 100
100 #endif // V8_MARK_COMPACT_INL_H_ 101 #endif // V8_MARK_COMPACT_INL_H_
OLDNEW
« no previous file with comments | « src/mark-compact.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698