Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 1810423002: [iOS/GN] Fix compilation of ios_chrome_unittests with gn. (Closed)

Created:
4 years, 9 months ago by sdefresne
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
cbentzel+watch_chromium.org, chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@resources
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS/GN] Fix compilation of ios_chrome_unittests with gn. Get GN in sync with gyp by adding missing dependencies, removing the obsoletes dependencies and adding missing files and targets. Change the toolchain when targetting iOS devices to not build fat binaries as this break the "gn gen"-time selection of the level of optimisation to use from skia and libwebp. Instead, building for devices on iOS is now similar to other platforms (i.e. the arch is selected via "target_cpu" with "arm" an alias for "armv7"). Fixes the following errors: Undefined symbols for architecture arm64: "_VP8DspInitNEON", referenced from: _VP8DspInit in dec.o ... BUG=459705, 596237 Committed: https://crrev.com/3bdd5635f4dba38c3035fe992039a833988e147b Cr-Commit-Position: refs/heads/master@{#383416}

Patch Set 1 #

Patch Set 2 : Rebase on origin/master #

Patch Set 3 : Fix "gn check out/Default" errors (pre-existing) #

Patch Set 4 : Synchronize with gyp changes #

Patch Set 5 : Fix link error when building for devices #

Patch Set 6 : Fix link error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -28 lines) Patch
M BUILD.gn View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M build/config/arm.gni View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M build/config/mac/BUILD.gn View 1 2 3 4 1 chunk +6 lines, -6 lines 0 comments Download
M build/toolchain/mac/BUILD.gn View 1 2 3 4 2 chunks +28 lines, -1 line 0 comments Download
M components/autofill/ios/browser/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/ios/BUILD.gn View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/policy/core/browser/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/BUILD.gn View 1 2 3 15 chunks +45 lines, -12 lines 0 comments Download
M ios/chrome/test/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ios/net/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (17 generated)
sdefresne
Please take a look. This obsolete your CL https://codereview.chromium.org/1725583002/.
4 years, 9 months ago (2016-03-18 17:22:39 UTC) #2
sdefresne
BTW the bots will probably fails as this depends on my webrtc fixes here: https://codereview.chromium.org/1812213002 ...
4 years, 9 months ago (2016-03-18 17:23:34 UTC) #3
Dirk Pranke
lgtm
4 years, 9 months ago (2016-03-18 17:57:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810423002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810423002/20001
4 years, 9 months ago (2016-03-25 17:26:39 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/9319)
4 years, 9 months ago (2016-03-25 17:35:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810423002/40001
4 years, 9 months ago (2016-03-25 18:10:46 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_gn/builds/9356)
4 years, 9 months ago (2016-03-25 18:22:06 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810423002/60001
4 years, 9 months ago (2016-03-25 18:28:43 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/9408)
4 years, 9 months ago (2016-03-25 20:04:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810423002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810423002/100001
4 years, 9 months ago (2016-03-25 23:41:47 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 9 months ago (2016-03-26 00:06:37 UTC) #27
commit-bot: I haz the power
4 years, 9 months ago (2016-03-26 00:07:58 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/3bdd5635f4dba38c3035fe992039a833988e147b
Cr-Commit-Position: refs/heads/master@{#383416}

Powered by Google App Engine
This is Rietveld 408576698