|
|
Chromium Code Reviews
Description[iOS] Link with base/maccocoathreadhelper.mm on iOS.
rtc::ThreadManager::ThreadManager() calls rtc::InitCocoaMultiThreading()
on iOS so add base/maccocoathreadhelper.mm to the file to build on iOS.
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"rtc::InitCocoaMultiThreading()", referenced from:
rtc::ThreadManager::ThreadManager() in librtc_base.a(thread.o)
BUG=459705
NOTRY=True
Committed: https://crrev.com/60624cd6bf29c75e02009bd6149ecfb9cb877c7b
Cr-Commit-Position: refs/heads/master@{#12085}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 17 (7 generated)
sdefresne@chromium.org changed reviewers: + kjellander@webrtc.org, perkj@webrtc.org
Please take a look.
lgtm, thanks for spotting this. Keeping GYP and GN in sync is hard. We have a PRESUBMIT checks as reminders, but I'm not aware of any better way to verify they're in sync. Some kind of diff tool for the ninja output would be ideal.
perkj: ping?
lgtm
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810373003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11951)
Description was changed from
==========
[iOS] Link with base/maccocoathreadhelper.mm on iOS.
rtc::ThreadManager::ThreadManager() calls rtc::InitCocoaMultiThreading()
on iOS so add base/maccocoathreadhelper.mm to the file to build on iOS.
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"rtc::InitCocoaMultiThreading()", referenced from:
rtc::ThreadManager::ThreadManager() in librtc_base.a(thread.o)
BUG=459705
==========
to
==========
[iOS] Link with base/maccocoathreadhelper.mm on iOS.
rtc::ThreadManager::ThreadManager() calls rtc::InitCocoaMultiThreading()
on iOS so add base/maccocoathreadhelper.mm to the file to build on iOS.
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"rtc::InitCocoaMultiThreading()", referenced from:
rtc::ThreadManager::ThreadManager() in librtc_base.a(thread.o)
BUG=459705
NOTRY=True
==========
On 2016/03/22 10:09:42, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > android_rel on tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11951) I'm setting NOTRY=True since an infra bug makes the symlink step fail on our bots. I'm reverting https://codereview.chromium.org/1818083003/ now to fix this.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810373003/1
Message was sent while issue was closed.
Description was changed from
==========
[iOS] Link with base/maccocoathreadhelper.mm on iOS.
rtc::ThreadManager::ThreadManager() calls rtc::InitCocoaMultiThreading()
on iOS so add base/maccocoathreadhelper.mm to the file to build on iOS.
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"rtc::InitCocoaMultiThreading()", referenced from:
rtc::ThreadManager::ThreadManager() in librtc_base.a(thread.o)
BUG=459705
NOTRY=True
==========
to
==========
[iOS] Link with base/maccocoathreadhelper.mm on iOS.
rtc::ThreadManager::ThreadManager() calls rtc::InitCocoaMultiThreading()
on iOS so add base/maccocoathreadhelper.mm to the file to build on iOS.
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"rtc::InitCocoaMultiThreading()", referenced from:
rtc::ThreadManager::ThreadManager() in librtc_base.a(thread.o)
BUG=459705
NOTRY=True
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
[iOS] Link with base/maccocoathreadhelper.mm on iOS.
rtc::ThreadManager::ThreadManager() calls rtc::InitCocoaMultiThreading()
on iOS so add base/maccocoathreadhelper.mm to the file to build on iOS.
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"rtc::InitCocoaMultiThreading()", referenced from:
rtc::ThreadManager::ThreadManager() in librtc_base.a(thread.o)
BUG=459705
NOTRY=True
==========
to
==========
[iOS] Link with base/maccocoathreadhelper.mm on iOS.
rtc::ThreadManager::ThreadManager() calls rtc::InitCocoaMultiThreading()
on iOS so add base/maccocoathreadhelper.mm to the file to build on iOS.
Fixes the following linker error:
Undefined symbols for architecture x86_64:
"rtc::InitCocoaMultiThreading()", referenced from:
rtc::ThreadManager::ThreadManager() in librtc_base.a(thread.o)
BUG=459705
NOTRY=True
Committed: https://crrev.com/60624cd6bf29c75e02009bd6149ecfb9cb877c7b
Cr-Commit-Position: refs/heads/master@{#12085}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/60624cd6bf29c75e02009bd6149ecfb9cb877c7b Cr-Commit-Position: refs/heads/master@{#12085} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
