Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 1810373002: openjpeg: Remove unneeded non-standard code. (Closed)

Created:
4 years, 9 months ago by Nico
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

openjpeg: Remove unneeded non-standard code. When building with clang-cl and not passing /FIintrin.h, the __attribute__ defined to nothing, which confuses the compiler (see bug). Since nothing seems to require the __attribute__ redefinition, just remove it. Reported upstream here: https://github.com/uclouvain/openjpeg/issues/727 BUG=592745 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/a051db3ff1a4d44138c149bb271f091f90ac98ec

Patch Set 1 #

Patch Set 2 : forgot patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -8 lines) Patch
A third_party/libopenjpeg20/0013-attrib_fix.patch View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/libopenjpeg20/README.pdfium View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/libopenjpeg20/opj_includes.h View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Nico
4 years, 9 months ago (2016-03-18 15:12:31 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-18 15:53:39 UTC) #4
Nico
4 years, 9 months ago (2016-03-18 18:09:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a051db3ff1a4d44138c149bb271f091f90ac98ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698