Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1810293002: Set sequential focus navigation starting point on scrollIntoView() (Closed)

Created:
4 years, 9 months ago by kochi
Modified:
4 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set sequential focus navigation starting point on scrollIntoView() BUG=594613 Committed: https://crrev.com/0bb887b20c70582eeafad2a58ac1650b7159f2b6 Cr-Commit-Position: refs/heads/master@{#382522}

Patch Set 1 #

Patch Set 2 : Use testRunner.findString() for testing findText. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/events/sequential-focus-navigation-starting-point.html View 1 1 chunk +23 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
kochi
tkent-san, Could you review?
4 years, 9 months ago (2016-03-18 10:52:35 UTC) #3
kochi
On 2016/03/18 10:52:35, kochi wrote: > tkent-san, > Could you review? BTW, I have no ...
4 years, 9 months ago (2016-03-18 10:53:54 UTC) #4
tkent
The code change looks ok. > BTW, I have no good idea how to test ...
4 years, 9 months ago (2016-03-21 23:34:05 UTC) #5
kochi
On 2016/03/21 23:34:05, tkent wrote: > The code change looks ok. > > > BTW, ...
4 years, 9 months ago (2016-03-22 05:54:27 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810293002/20001
4 years, 9 months ago (2016-03-22 05:54:47 UTC) #8
tkent
lgtm
4 years, 9 months ago (2016-03-22 05:56:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810293002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810293002/20001
4 years, 9 months ago (2016-03-22 06:02:09 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-22 07:04:26 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-22 07:06:15 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bb887b20c70582eeafad2a58ac1650b7159f2b6
Cr-Commit-Position: refs/heads/master@{#382522}

Powered by Google App Engine
This is Rietveld 408576698