Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1810293002: Set sequential focus navigation starting point on scrollIntoView() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use testRunner.findString() for testing findText. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 455 matching lines...) Expand 10 before | Expand all | Expand 10 after
466 return; 466 return;
467 467
468 bool makeVisibleInVisualViewport = !document().page()->settings().inertVisua lViewport(); 468 bool makeVisibleInVisualViewport = !document().page()->settings().inertVisua lViewport();
469 469
470 LayoutRect bounds = boundingBox(); 470 LayoutRect bounds = boundingBox();
471 // Align to the top / bottom and to the closest edge. 471 // Align to the top / bottom and to the closest edge.
472 if (alignToTop) 472 if (alignToTop)
473 layoutObject()->scrollRectToVisible(bounds, ScrollAlignment::alignToEdge IfNeeded, ScrollAlignment::alignTopAlways, ProgrammaticScroll, makeVisibleInVisu alViewport); 473 layoutObject()->scrollRectToVisible(bounds, ScrollAlignment::alignToEdge IfNeeded, ScrollAlignment::alignTopAlways, ProgrammaticScroll, makeVisibleInVisu alViewport);
474 else 474 else
475 layoutObject()->scrollRectToVisible(bounds, ScrollAlignment::alignToEdge IfNeeded, ScrollAlignment::alignBottomAlways, ProgrammaticScroll, makeVisibleInV isualViewport); 475 layoutObject()->scrollRectToVisible(bounds, ScrollAlignment::alignToEdge IfNeeded, ScrollAlignment::alignBottomAlways, ProgrammaticScroll, makeVisibleInV isualViewport);
476
477 document().setSequentialFocusNavigationStartingPoint(this);
476 } 478 }
477 479
478 void Element::scrollIntoViewIfNeeded(bool centerIfNeeded) 480 void Element::scrollIntoViewIfNeeded(bool centerIfNeeded)
479 { 481 {
480 document().updateLayoutIgnorePendingStylesheets(); 482 document().updateLayoutIgnorePendingStylesheets();
481 483
482 if (!layoutObject()) 484 if (!layoutObject())
483 return; 485 return;
484 486
485 bool makeVisibleInVisualViewport = !document().page()->settings().inertVisua lViewport(); 487 bool makeVisibleInVisualViewport = !document().page()->settings().inertVisua lViewport();
(...skipping 3176 matching lines...) Expand 10 before | Expand all | Expand 10 after
3662 { 3664 {
3663 #if ENABLE(OILPAN) 3665 #if ENABLE(OILPAN)
3664 if (hasRareData()) 3666 if (hasRareData())
3665 visitor->trace(elementRareData()); 3667 visitor->trace(elementRareData());
3666 visitor->trace(m_elementData); 3668 visitor->trace(m_elementData);
3667 #endif 3669 #endif
3668 ContainerNode::trace(visitor); 3670 ContainerNode::trace(visitor);
3669 } 3671 }
3670 3672
3671 } // namespace blink 3673 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698