Check for unstable types in IPC messages.

tools/clang/plugins/FindBadConstructsConsumer.cpp

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "FindBadConstructsConsumer.h"
 
 #include "clang/Frontend/CompilerInstance.h"
 #include "clang/AST/Attr.h"
 #include "clang/Lex/Lexer.h"
+#include "clang/Sema/Sema.h"
 #include "llvm/Support/raw_ostream.h"
 
 using namespace clang;
 
 namespace chrome_checker {
 
 namespace {
 
 const char kMethodRequiresOverride[] =
     "[chromium-style] Overriding method must be marked with 'override' or "
@@ skipping 71 matching lines @@
   return FixItHint::CreateRemoval(range);
 }
 
 bool IsPodOrTemplateType(const CXXRecordDecl& record) {
   return record.isPOD() ||
          record.getDescribedClassTemplate() ||
          record.getTemplateSpecializationKind() ||
          record.isDependentType();
 }
 
+// Use a local RAV implementation to simply collect all FunctionDecls marked for
+// late template parsing. This happens with the flag -fdelayed-template-parsing,
+// which is on by default in MSVC-compatible mode.
+std::set<FunctionDecl*> GetLateParsedFunctionDecls(TranslationUnitDecl* decl) {
+  struct Visitor : public RecursiveASTVisitor<Visitor> {
+    bool VisitFunctionDecl(FunctionDecl* function_decl) {
+      if (function_decl->isLateTemplateParsed())
+        late_parsed_decls.insert(function_decl);
+      return true;
+    }
+
+    std::set<FunctionDecl*> late_parsed_decls;
+  } v;
+  v.TraverseDecl(decl);
+  return v.late_parsed_decls;
+}
+
 }  // namespace
 
 FindBadConstructsConsumer::FindBadConstructsConsumer(CompilerInstance& instance,
                                                      const Options& options)
     : ChromeClassTester(instance, options) {
+  if (options.check_ipc) {
+    ipc_visitor_.reset(new CheckIPCVisitor(instance));
+  }
+
   // Messages for virtual method specifiers.
   diag_method_requires_override_ =
       diagnostic().getCustomDiagID(getErrorLevel(), kMethodRequiresOverride);
   diag_redundant_virtual_specifier_ =
       diagnostic().getCustomDiagID(getErrorLevel(), kRedundantVirtualSpecifier);
   diag_base_method_virtual_and_final_ =
       diagnostic().getCustomDiagID(getErrorLevel(), kBaseMethodVirtualAndFinal);
 
   // Messages for destructors.
   diag_no_explicit_dtor_ =
@@ skipping 13 matching lines @@
   diag_note_inheritance_ =
       diagnostic().getCustomDiagID(DiagnosticsEngine::Note, kNoteInheritance);
   diag_note_implicit_dtor_ =
       diagnostic().getCustomDiagID(DiagnosticsEngine::Note, kNoteImplicitDtor);
   diag_note_public_dtor_ =
       diagnostic().getCustomDiagID(DiagnosticsEngine::Note, kNotePublicDtor);
   diag_note_protected_non_virtual_dtor_ = diagnostic().getCustomDiagID(
       DiagnosticsEngine::Note, kNoteProtectedNonVirtualDtor);
 }
 
+void FindBadConstructsConsumer::Traverse(ASTContext& context) {
+  if (ipc_visitor_) {
+    ipc_visitor_->set_context(&context);
+    ParseFunctionTemplates(context.getTranslationUnitDecl());
+  }
+  RecursiveASTVisitor::TraverseDecl(context.getTranslationUnitDecl());
+  if (ipc_visitor_) ipc_visitor_->set_context(nullptr);
+}
+
+bool FindBadConstructsConsumer::TraverseDecl(Decl* decl) {
+  if (ipc_visitor_) ipc_visitor_->BeginDecl(decl);
+  bool result = RecursiveASTVisitor::TraverseDecl(decl);
+  if (ipc_visitor_) ipc_visitor_->EndDecl();
+  return result;
+}
+
 bool FindBadConstructsConsumer::VisitDecl(clang::Decl* decl) {
   clang::TagDecl* tag_decl = dyn_cast<clang::TagDecl>(decl);
   if (tag_decl && tag_decl->isCompleteDefinition())
     CheckTag(tag_decl);
   return true;
 }
 
+bool FindBadConstructsConsumer::VisitTemplateSpecializationType(
+    TemplateSpecializationType* spec) {
+  if (ipc_visitor_) ipc_visitor_->VisitTemplateSpecializationType(spec);
+  return true;
+}
+
+bool FindBadConstructsConsumer::VisitCallExpr(CallExpr* call_expr) {
+  if (ipc_visitor_) ipc_visitor_->VisitCallExpr(call_expr);
+  return true;
+}
+
 void FindBadConstructsConsumer::CheckChromeClass(SourceLocation record_location,
                                                  CXXRecordDecl* record) {
   // By default, the clang checker doesn't check some types (templates, etc).
   // That was only a mistake; once Chromium code passes these checks, we should
   // remove the "check-templates" option and remove this code.
   // See crbug.com/441916
   if (!options_.check_templates && IsPodOrTemplateType(*record))
     return;
 
   bool implementation_file = InImplementationFile(record_location);
@@ skipping 713 matching lines @@
     // If we've already seen a WeakPtrFactory<OwningType> and this param is not
     // one of those, it means there is at least one member after a factory.
     if (weak_ptr_factory_location.isValid() &&
         !param_is_weak_ptr_factory_to_self) {
       diagnostic().Report(weak_ptr_factory_location,
                           diag_weak_ptr_factory_order_);
     }
   }
 }
 
+void FindBadConstructsConsumer::ParseFunctionTemplates(
+    TranslationUnitDecl* decl) {
+  if (!instance().getLangOpts().DelayedTemplateParsing)
+    return;  // Nothing to do.
+
+  std::set<FunctionDecl*> late_parsed_decls = GetLateParsedFunctionDecls(decl);
+  clang::Sema& sema = instance().getSema();
+
+  for (const FunctionDecl* fd : late_parsed_decls) {
+    assert(fd->isLateTemplateParsed());
+
+    // Force parsing and AST building of the yet-uninstantiated function
+    // template trace method bodies.

[dcheng, 2016/03/30 18:29:22]

Fix this comment. Also, how come we don't need to ignore system headers like
https://codereview.chromium.org/1135333007 did?

+    clang::LateParsedTemplate* lpt = sema.LateParsedTemplateMap[fd];
+    sema.LateTemplateParser(sema.OpaqueParser, *lpt);
+  }
+}
+
 }  // namespace chrome_checker