Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1135333007: Revert of Revert "win: Make oilpan plugin work better with delayed template parsing." (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Make oilpan plugin work better with delayed template parsing. This time with correct copyright headers. On Windows, clang-cl only parses template methods that are referenced (-fdelayed-template-parsing), so members traced from unreferenced template methods weren't seen by the plugin, which caused it to warn about them. Explicitly parse delayed template methods that look like they are trace methods and that aren't in system headers to work around this. This is based on Kim Grasman's patch for the IWYU project: https://code.google.com/p/include-what-you-use/source/detail?r=566 Together with clang r237531 ( http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150511/129285.html ) this should fix all failing oilpan plugin tests on Windows. BUG=486571 TBR=hans Committed: https://crrev.com/2b87ce49a909879a6538632fd4e990c4bd15f4c9 Cr-Commit-Position: refs/heads/master@{#330295}

Patch Set 1 #

Patch Set 2 : copyright #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -1 line) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 1 4 chunks +45 lines, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/Config.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
A tools/clang/blink_gc_plugin/tests/delayed_parsing.cpp View 1 1 chunk +25 lines, -0 lines 0 comments Download
A tools/clang/blink_gc_plugin/tests/delayed_parsing.flags View 1 1 chunk +1 line, -0 lines 0 comments Download
A + tools/clang/blink_gc_plugin/tests/delayed_parsing.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Nico
Created Revert of Revert "win: Make oilpan plugin work better with delayed template parsing."
5 years, 7 months ago (2015-05-17 01:30:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135333007/160001
5 years, 7 months ago (2015-05-17 01:41:49 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-17 01:41:51 UTC) #5
Nico
Accidentally removed the TBR line while fixing up the commit description. (This is identical to ...
5 years, 7 months ago (2015-05-17 01:46:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135333007/160001
5 years, 7 months ago (2015-05-17 01:46:40 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:160001)
5 years, 7 months ago (2015-05-17 01:53:38 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2b87ce49a909879a6538632fd4e990c4bd15f4c9 Cr-Commit-Position: refs/heads/master@{#330295}
5 years, 7 months ago (2015-05-18 11:32:16 UTC) #10
hans
5 years, 7 months ago (2015-05-18 16:15:05 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698