Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1810223002: [Media Router UI] Fix search results overflow scroll and input focus. (Closed)

Created:
4 years, 9 months ago by btolsch
Modified:
4 years, 9 months ago
Reviewers:
apacible
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

[Media Router UI] Fix search results overflow scroll and input focus. This change fixes the following issues: - The full search result list is not accessible when scrolling is necessary. - The input focus logic is broken by keyboard tabbing wrapping around the document. This change was dependent on this CL, which was also after M50 branched: https://codereview.chromium.org/1772813002/ This change includes everything from both that is necessary. BUG=594789 R=apacible@chromium.org NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1801983003 Cr-Commit-Position: refs/heads/master@{#381272} (cherry picked from commit aa85d103c33578539738cb88f163f33deb344266)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -4 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 5 chunks +101 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
btolsch
I was able to fix it by running drover again and fixing the patch before ...
4 years, 9 months ago (2016-03-17 23:34:49 UTC) #1
apacible
lgtm thanks!
4 years, 9 months ago (2016-03-18 17:59:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810223002/1
4 years, 9 months ago (2016-03-18 20:06:48 UTC) #5
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 9 months ago (2016-03-18 20:06:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1810223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1810223002/1
4 years, 9 months ago (2016-03-18 20:09:50 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-18 20:11:10 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698