Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1801983003: [Media Router UI] Fix search results overflow scroll and input focus. (Closed)

Created:
4 years, 9 months ago by btolsch
Modified:
4 years, 9 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router UI] Fix search results overflow scroll and input focus. This change fixes the following issues: - The full search result list is not accessible when scrolling is necessary. - The input focus logic is broken by keyboard tabbing wrapping around the document. BUG=594789 R=apacible@chromium.org Committed: https://crrev.com/aa85d103c33578539738cb88f163f33deb344266 Cr-Commit-Position: refs/heads/master@{#381272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -15 lines) Patch
M chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js View 4 chunks +65 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
btolsch
PTAL, thanks!
4 years, 9 months ago (2016-03-14 22:49:03 UTC) #1
apacible
lgtm
4 years, 9 months ago (2016-03-15 17:18:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1801983003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1801983003/1
4 years, 9 months ago (2016-03-15 17:37:59 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-15 19:01:00 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-15 19:02:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa85d103c33578539738cb88f163f33deb344266
Cr-Commit-Position: refs/heads/master@{#381272}

Powered by Google App Engine
This is Rietveld 408576698